public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 0/1] Fix problem with devtool and BBCLASSEXTENDed recipes
Date: Sat, 17 Sep 2016 03:18:07 +0200	[thread overview]
Message-ID: <cover.1474075036.git.pkj@axis.com> (raw)

Is no one using devtool with BBCLASSEXTENDed recipes? Because when I
tried that today I noticed that after having done "devtool modify -x
foo-native" the recipe would not rebuild after having changed the
source code (the way it does for non-native recipes).

As far as I can tell the problem is that externalsrc.bbclass sets
BB_DONT_CACHE inside an anonymous Python function after having checked
if EXTERNALSRC is set. However, for BBCLASSEXTENDed recipes
BB_DONT_CACHE needs to be set for the base recipe rather than the
current variant. Why this is, I have no idea.

First I thought of unconditionally setting BB_DONT_CACHE in the
externalsrc bbclass, but then I realized that people may be used to,
e.g., inherit externalsrc in their local.conf and that would
effectively cause every recipe to be reparsed every time bitbake is
executed...

Eventually I managed to implement a solution that seems to work and
only sets BB_DONT_CACHE as necessary. It may not be kosher as it looks
at overridden variants of EXTERNALSRC, but it was the best I could
come up with.

I know too little of the recipe parsing internals to be able to tell
whether the current behavior is working as intended or if it is a bug
that BB_DONT_CACHE must be set for the base recipe. I leave that for
someone more knowledgeable in the parsing internals to investigate.

//Peter

The following changes since commit 5414b80e8df11188d8e67a37185305c34ea084bd:

  bitbake: cooker: check if target contains task (2016-09-16 15:24:03 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib pkj/externalsrc_dont_cache
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/externalsrc_dont_cache

Peter Kjellerstedt (1):
  externalsrc.bbclass: Make reparsing work for BBCLASSEXTENDed recipes

 meta/classes/externalsrc.bbclass | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

-- 
2.9.0



             reply	other threads:[~2016-09-17  1:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-17  1:18 Peter Kjellerstedt [this message]
2016-09-17  1:18 ` [PATCH 1/1] externalsrc.bbclass: Make reparsing work for BBCLASSEXTENDed recipes Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1474075036.git.pkj@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox