Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 00/11] wic refactoring (almost done)
Date: Wed, 15 Feb 2017 10:38:23 +0200	[thread overview]
Message-ID: <cover.1487110279.git.ed.bartosh@linux.intel.com> (raw)

Hi,

This patchset takes care of logging and error handling:
- remove custom msger module in favor of standard python logging
- raise WicError exception instead of calling sys.exit

This is the one of the last changes for this time.

I'm thinking about refactoring wic plugin system, but haven't decided yet
if it makes sense to do right now or not. Other than that I'm happy with
the state of the wic codebase for now. There are still many things to improve,
but it looks and feels much better now.

The following changes since commit 10d1f08f71a623ca6d45cf0ae1afa2e880591a09:

  wic: direct: move creation of PartitionedImage to __init__ (2017-02-10 16:44:03 +0200)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ed/wic/wip
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip

Ed Bartosh (11):
  wic: setup logging in the main wic module
  wic: use wic logger in core modules
  wic: use wic logger in imager direct plugin
  wic: use wic logger in wic source plugins
  wic: remove msger module
  wic: move errors module
  wic: raise WicError in main module
  wic: raise WicError in core modules
  wic: raise WicError in wic plugins
  wic: raise WicError instead of ImageError and CreatorError
  wic: move WicError to lib/wic/__init__.py

 scripts/lib/wic/__init__.py                        |  20 ++
 scripts/lib/wic/engine.py                          |  28 ++-
 scripts/lib/wic/help.py                            |   8 +-
 scripts/lib/wic/ksparser.py                        |   7 +-
 scripts/lib/wic/msger.py                           | 209 ---------------------
 scripts/lib/wic/partition.py                       |  68 +++----
 scripts/lib/wic/plugin.py                          |  24 +--
 scripts/lib/wic/pluginbase.py                      |  12 +-
 scripts/lib/wic/plugins/imager/direct.py           |  87 ++++-----
 scripts/lib/wic/plugins/source/bootimg-efi.py      |  52 ++---
 .../lib/wic/plugins/source/bootimg-partition.py    |  25 +--
 scripts/lib/wic/plugins/source/bootimg-pcbios.py   |  41 ++--
 scripts/lib/wic/plugins/source/fsimage.py          |  14 +-
 .../lib/wic/plugins/source/isoimage-isohybrid.py   |  79 ++++----
 scripts/lib/wic/plugins/source/rawcopy.py          |  12 +-
 scripts/lib/wic/plugins/source/rootfs.py           |  21 ++-
 .../lib/wic/plugins/source/rootfs_pcbios_ext.py    |  54 +++---
 scripts/lib/wic/utils/errors.py                    |  29 ---
 scripts/lib/wic/utils/misc.py                      |  34 ++--
 scripts/lib/wic/utils/runner.py                    |  12 +-
 scripts/wic                                        | 104 +++++-----
 21 files changed, 378 insertions(+), 562 deletions(-)
 delete mode 100644 scripts/lib/wic/msger.py
 delete mode 100644 scripts/lib/wic/utils/errors.py

--
Regards,
Ed



             reply	other threads:[~2017-02-15  9:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15  8:38 Ed Bartosh [this message]
2017-02-15  8:38 ` [PATCH 01/11] wic: setup logging in the main wic module Ed Bartosh
2017-02-15  8:38 ` [PATCH 02/11] wic: use wic logger in core modules Ed Bartosh
2017-02-15  8:38 ` [PATCH 03/11] wic: use wic logger in imager direct plugin Ed Bartosh
2017-02-15  8:38 ` [PATCH 04/11] wic: use wic logger in wic source plugins Ed Bartosh
2017-02-15  8:38 ` [PATCH 05/11] wic: remove msger module Ed Bartosh
2017-02-15  8:38 ` [PATCH 06/11] wic: move errors module Ed Bartosh
2017-02-15  8:38 ` [PATCH 07/11] wic: raise WicError in main module Ed Bartosh
2017-02-15  8:38 ` [PATCH 08/11] wic: raise WicError in core modules Ed Bartosh
2017-02-15  8:38 ` [PATCH 09/11] wic: raise WicError in wic plugins Ed Bartosh
2017-02-15  8:38 ` [PATCH 10/11] wic: raise WicError instead of ImageError and CreatorError Ed Bartosh
2017-02-15  8:38 ` [PATCH 11/11] wic: move WicError to lib/wic/__init__.py Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1487110279.git.ed.bartosh@linux.intel.com \
    --to=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox