* [PATCHv2 1/1] oeqa/core/loader.py: Do not import underscore modules by default
2017-03-27 20:05 [PATCHv2 0/1] oeqa/core/loader.py: Do not import underscore modules by default mariano.lopez
@ 2017-03-27 20:05 ` mariano.lopez
0 siblings, 0 replies; 2+ messages in thread
From: mariano.lopez @ 2017-03-27 20:05 UTC (permalink / raw)
To: openembedded-core
From: Mariano Lopez <mariano.lopez@linux.intel.com>
Underscore modules are meant to be run only when manually added to the test
suite, so far another mechanisms are in place to make this happen with
runtime, sdk, and esdk (mostly in test* bbclasses).
This will add such functionality in the core framework so other specific
frameworks can take use this without adding something else.
[YOCTO #10980]
Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
---
meta/lib/oeqa/core/loader.py | 34 ++++++++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/meta/lib/oeqa/core/loader.py b/meta/lib/oeqa/core/loader.py
index 74f1117..63a1703 100644
--- a/meta/lib/oeqa/core/loader.py
+++ b/meta/lib/oeqa/core/loader.py
@@ -223,8 +223,21 @@ class OETestLoader(unittest.TestLoader):
msg = 'Tried to import %s test module but is a built-in'
raise ImportError(msg % module.__name__)
- if not self.modules or "all" in self.modules or \
- module.__name__ in self.modules:
+ # Normal test modules are loaded if no modules were specified,
+ # if module is in the specified module list or if 'all' is in
+ # module list.
+ # Underscore modules are loaded only if specified in module list.
+ load_module = True if not module.__name__.startswith('_') \
+ and (not self.modules \
+ or module.__name__ in self.modules \
+ or 'all' in self.modules) \
+ else False
+
+ load_underscore = True if module.__name__.startswith('_') \
+ and module.__name__ in self.modules \
+ else False
+
+ if load_module or load_underscore:
return super(OETestLoader, self).loadTestsFromModule(
module, *args, pattern=pattern, **kws)
else:
@@ -238,8 +251,21 @@ class OETestLoader(unittest.TestLoader):
msg = 'Tried to import %s test module but is a built-in'
raise ImportError(msg % module.__name__)
- if not self.modules or "all" in self.modules or \
- module.__name__ in self.modules:
+ # Normal test modules are loaded if no modules were specified,
+ # if module is in the specified module list or if 'all' is in
+ # module list.
+ # Underscore modules are loaded only if specified in module list.
+ load_module = True if not module.__name__.startswith('_') \
+ and (not self.modules \
+ or module.__name__ in self.modules \
+ or 'all' in self.modules) \
+ else False
+
+ load_underscore = True if module.__name__.startswith('_') \
+ and module.__name__ in self.modules \
+ else False
+
+ if load_module or load_underscore:
return super(OETestLoader, self).loadTestsFromModule(
module, use_load_tests)
else:
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread