From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bes.se.axis.com (bes.se.axis.com [195.60.68.10]) by mail.openembedded.org (Postfix) with ESMTP id 1201D77D88 for ; Thu, 13 Apr 2017 12:23:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by bes.se.axis.com (Postfix) with ESMTP id E9C492E5A2 for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bes.se.axis.com Received: from bes.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bes.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id obyqS19AtNW8 for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) Received: from boulder03.se.axis.com (boulder03.se.axis.com [10.0.8.17]) by bes.se.axis.com (Postfix) with ESMTPS id 35F962E2C2 for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) Received: from boulder03.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 20AEA1E082 for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) Received: from boulder03.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 15F7D1E081 for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) Received: from seth.se.axis.com (unknown [10.0.2.172]) by boulder03.se.axis.com (Postfix) with ESMTP for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) Received: from saur-2.se.axis.com (saur-2.se.axis.com [10.92.3.2]) by seth.se.axis.com (Postfix) with ESMTP id 09FAE3206 for ; Thu, 13 Apr 2017 14:23:59 +0200 (CEST) Received: from saur-2.se.axis.com (localhost [127.0.0.1]) by saur-2.se.axis.com (8.14.5/8.14.5) with ESMTP id v3DCNwsx013623 for ; Thu, 13 Apr 2017 14:23:58 +0200 Received: (from pkj@localhost) by saur-2.se.axis.com (8.14.5/8.14.5/Submit) id v3DCNwmN013622 for openembedded-core@lists.openembedded.org; Thu, 13 Apr 2017 14:23:58 +0200 From: Peter Kjellerstedt To: openembedded-core@lists.openembedded.org Date: Thu, 13 Apr 2017 14:23:56 +0200 Message-Id: X-Mailer: git-send-email 2.12.0 X-TM-AS-GCONF: 00 Subject: [PATCH 0/1] Do not use command in profile X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 12:24:00 -0000 Since we apparently cannot rely on the command utility to always exist, it is better to avoid using it in the profile script. Rather than using command to detect if tty and resize exist (which obviously will not work if command itself does not exist), just call them directly while piping any output for stderr to /dev/null. This should actually be a little bit more efficient in the case that they do exist, and the same in the case that they do not exist. I leave to you to decide whether you want to revert commit e41c90b852 that enabled the command utility in busybox or not. //Peter The following changes since commit fe47bff64b17562593c620d2daf748735bb5c3d6: linux-yocto: Update genericx86* SRCREVs for linux-yocto 4.10 (2017-04-13 10:54:37 +0100) are available in the git repository at: git://git.yoctoproject.org/poky-contrib pkj/profile_without_command http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/profile_without_command Peter Kjellerstedt (1): base-files: profile: Avoid using "command" to determine if programs exist meta/recipes-core/base-files/base-files/profile | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) -- 2.12.0