Re: [OE-core][dunfell 00/28] Patch review - pseudo file mode corruption fix series

Paul Barker
2020-12-22T15:09:20Z

On Tue, 22 Dec 2020 at 14:57, Erik Botö <erik.boto@gmail.com> wrote:
>
> On Tue, Dec 22, 2020 at 2:50 PM Paul Barker <pbarker@konsulko.com> wrote:
> >
> > On Tue, 22 Dec 2020 at 10:03, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> > >
> > > On Tue, 2020-12-22 at 10:08 +0100, Erik Boto wrote:
> > > > There's a bug affecting wic in combination with --exclude-path /
> > > > --include-path that would then be backported into the LTS version.
> > > > See
> > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14129.
> > > >
> > > > Maybe the issue that is being fixed is more serious then the issue
> > > > being introduced so it's a valid trade-off, I just wanted to mention
> > > > it so it's known.
> > >
> > > I've been suggesting Steve hold off this until we sorted out master,
> > > having a patch queue ready is helpful though so we don't lose track of
> > > all the patches.
> > >
> > > There were some fixes from Peter/Paul around pseudo which we needed and
> > > have now merged which leaves the above issue...
> > >
> > > Cheers,
> > >
> > > Richard
> >
> > Looking at that bug (#14129) I wonder why "${WORKDIR}/build-wic" was
> > added to PSEUDO_IGNORE_PATHS in
> > https://git.openembedded.org/openembedded-core/commit/?id=ad8f5532ffaead9a5ad13e1034fe9e5e1b7979f4.
> > Is anything likely to explode if we drop that addition?
>
> Yes, if you try to build an image a second time it breaks and you have
> to "bitbake -c clean <image>" in order to build it successfully again.
> I don't recall the exact error at this time, but it was related to the
> partition files wic created under build-wic.

Ok. Sounds like we need to move the directory wic uses when copying
the rootfs out of "${WORKDIR}/build-wic" so that it can be tracked by
pseudo. The partition files should stay in the build-wic directory.

--
Paul Barker
Konsulko Group