Re: [OE-core][dunfell 00/28] Patch review - pseudo file mode corruption fix series

Erik Boto
2020-12-22T09:09:05Z

There's a bug affecting wic in combination with --exclude-path /
--include-path that would then be backported into the LTS version. See
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14129.

Maybe the issue that is being fixed is more serious then the issue
being introduced so it's a valid trade-off, I just wanted to mention
it so it's known.

Cheers,
Erik

On Mon, Dec 21, 2020 at 4:06 PM Steve Sakoman <steve@sakoman.com> wrote:
>
> On Mon, Dec 21, 2020 at 4:33 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > Just curious, is this PR on hold or rejected completely?
> >
> > I don't have strong opinion either way, I was just wondering about this one when other newer PRs were already merged.
>
> This series is still actively being tested. I've been waiting for a
> couple of related patches from master to hit before sending a v2.
>
> If there are still no objections at that point I'll send a merge request.
>
> Steve
>
> > On Thu, Dec 3, 2020 at 4:08 PM Steve Sakoman <steve@sakoman.com> wrote:
> >>
> >> Issues with undetected file mode corruption in pseudo have been identified.
> >>
> >> Fixes have been merged into master and gatesgarth over the past couple of months and
> >> things seem to have stabilized enough that we can consider backporting these fixes
> >> to dunfell.
> >>
> >> This is a somewhat more invasive change than normal. Specifically the user will
> >> be required to clean TMPDIR after this merge. It may also expose issues with
> >> other layers, though master and gategarth have probably helped to pave the way for
> >> this change.
> >>
> >> Personally I think that this fixes a serious enough issue that we should consider
> >> this series for dunfell.
> >>
> >> Please have comments back by Monday morning.
> >>
> >> The following changes since commit 071806feb195961e59069f778c9ae8f27a739d9a:
> >>
> >> e2fsprogs: Fix a ptest permissions determinism issue (2020-11-30 12:05:57 -1000)
> >>
> >> are available in the Git repository at:
> >>
> >> git://git.openembedded.org/openembedded-core-contrib stable/dunfell-nut
> >> http://cgit.openembedded.org/openembedded-core-contrib/log/?h=stable/dunfell-nut
> >>
> >> Jacob Kroon (1):
> >> bitbake.conf: Remove TERM from default BB_HASHBASE_WHITELIST
> >>
> >> Joe Slater (1):
> >> pseudo: fix renaming to self
> >>
> >> Martin Jansa (1):
> >> base.bbclass: use os.path.normpath instead of just comparing WORKDIR
> >> and S as strings
> >>
> >> Mingli Yu (2):
> >> tcl: adapt to potential pseudo changes
> >> bitbake.conf: Exclude ${CCACHE_DIR} from pseudo database
> >>
> >> Ricardo Ribalda Delgado (3):
> >> wic: Fix permissions when using exclude or include path
> >> wic: Fix multi images .wks with bitbake
> >> wic: Avoid creating invalid pseudo directory
> >>
> >> Richard Purdie (19):
> >> pseudo: Switch to oe-core branch in git repo
> >> pseudo: merge in fixes for setfacl issue
> >> pseudo: Update to add OFC fcntl lock updates
> >> pseudo: Ignore mismatched inodes from the db
> >> pseudo: Add support for ignoring paths from the pseudo DB
> >> pseudo: Abort on mismatch patch
> >> psuedo: Add tracking of linked files for fds
> >> pseudo: Fix xattr segfault
> >> pseudo: Add may unlink patch
> >> pseudo: Add pathfix patch
> >> base/bitbake.conf: Enable pseudo path filtering
> >> wic: Handle new PSEUDO_IGNORE_PATHS variable
> >> pseudo: Fix statx function usage
> >> bitbake.conf: Extend PSEUDO_IGNORE_PATHS to ${COREBASE}/meta
> >> abi_version,sanity: Tell users TMPDIR must be clean after pseudo
> >> changes
> >> pseudo: Update to account for patches merged on branch
> >> pseudo: Upgrade to include mkostemp64 wrapper
> >> oeqa/selftest/runtime_test: Exclude gpg directory from pseudo database
> >> uninative: Don't use single sstate for pseudo-native
> >>
> >> Ross Burton (1):
> >> devtool: remove unused variable
> >>
> >> meta/classes/archiver.bbclass | 2 +-
> >> meta/classes/base.bbclass | 6 +
> >> meta/classes/image_types_wic.bbclass | 12 +-
> >> meta/classes/populate_sdk_base.bbclass | 2 +
> >> meta/classes/sanity.bbclass | 3 +
> >> meta/classes/sstate.bbclass | 4 +
> >> meta/conf/abi_version.conf | 2 +-
> >> meta/conf/bitbake.conf | 13 +-
> >> meta/lib/oe/sstatesig.py | 4 +-
> >> meta/lib/oeqa/selftest/cases/runtime_test.py | 1 +
> >> .../pseudo/files/0001-Add-statx.patch | 106 --------------
> >> ...001-maketables-wrappers-use-Python-3.patch | 34 -----
> >> ...ixup-remove-files-that-do-not-exist-.patch | 49 -------
> >> .../0001-pseudo_ipc.h-Fix-enum-typedef.patch | 31 ----
> >> ...1-realpath.c-Remove-trailing-slashes.patch | 57 --------
> >> ...xattr-adjust-for-attr-2.4.48-release.patch | 48 ------
> >> .../pseudo/files/moreretries.patch | 19 ---
> >> .../pseudo/files/seccomp.patch | 137 ------------------
> >> .../pseudo/files/toomanyfiles.patch | 71 ---------
> >> .../pseudo/files/xattr_version.patch | 54 -------
> >> meta/recipes-devtools/pseudo/pseudo_git.bb | 14 +-
> >> meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
> >> scripts/lib/devtool/standard.py | 1 -
> >> scripts/lib/wic/partition.py | 23 +--
> >> scripts/lib/wic/plugins/source/rootfs.py | 37 ++++-
> >> scripts/postinst-intercepts/update_font_cache | 2 +
> >> 26 files changed, 89 insertions(+), 644 deletions(-)
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/0001-Add-statx.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/0001-maketables-wrappers-use-Python-3.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/0001-pseudo-On-a-DB-fixup-remove-files-that-do-not-exist-.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/0001-pseudo_ipc.h-Fix-enum-typedef.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/0001-realpath.c-Remove-trailing-slashes.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/0006-xattr-adjust-for-attr-2.4.48-release.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/moreretries.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/seccomp.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/toomanyfiles.patch
> >> delete mode 100644 meta/recipes-devtools/pseudo/files/xattr_version.patch
> >>
> >> --
> >> 2.17.1
> >>
> >>
> >>
> >>
>
>
>