From: "Steve Sakoman" <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][dunfell V3 00/46] Patch review - pseudo file mode corruption fix V3
Date: Tue, 26 Jan 2021 04:41:11 -1000 [thread overview]
Message-ID: <cover.1611671734.git.steve@sakoman.com> (raw)
Issues with undetected file mode corruption in pseudo have been identified.
Fixes have been merged into master and gatesgarth over the past several months and
things seem to have stabilized enough that we can consider backporting these fixes
to dunfell.
This is a somewhat more invasive change than normal. Specifically the user will
be required to clean TMPDIR after this merge. It may also expose issues with
other layers, though master and gategarth have probably helped to pave the way for
this change.
Personally I think that this fixes a serious enough issue that we should consider
this series for dunfell.
This third version removes:
bitbake.conf: Remove TERM from default BB_HASHBASE_WHITELIST
and hence the need for any bitbake changes.
Let me know if you you are aware of any other pseudo issues which would necessitate
delaying the merge of this series.
Please have comments back by Thursday evening.
Passed a-full on autobuilder:
https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1784
The following changes since commit 897822233faef0f8f35dc1d8a39e1c4bc0550f1e:
ppp: Whitelist CVE-2020-15704 (2021-01-19 04:22:10 -1000)
are available in the Git repository at:
git://git.openembedded.org/openembedded-core-contrib stable/dunfell-nut
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=stable/dunfell-nut
Jack Mitchell (1):
distutils3: allow setup.py to be run from a different directory to
${S}
Joe Slater (1):
pseudo: fix renaming to self
Martin Jansa (2):
base.bbclass: use os.path.normpath instead of just comparing WORKDIR
and S as strings
license.bbclass: Add COMMON_LICENSE_DIR and LICENSE_PATH dirs to
PSEUDO_IGNORE_PATHS
Mingli Yu (2):
tcl: adapt to potential pseudo changes
bitbake.conf: Exclude ${CCACHE_DIR} from pseudo database
Paul Barker (8):
bitbake.conf: Prevent pyc file generation in pseudo context
wic: Add workdir argument
wic: Allow exec_native_cmd to run HOSTTOOLS
wic: Ensure internal workdir is not reused
image_types_wic: Move wic working directory
wic: Update pseudo db when excluding content from rootfs
wic: Copy rootfs dir if fstab needs updating
wic: Optimise fstab modification for ext2/3/4 and msdos partitions
Peter Kjellerstedt (4):
pseudo: Simplify pseudo_client_ignore_path_chroot()
lib/oe/path: Add canonicalize()
bitbake.conf: Canonicalize paths in PSEUDO_IGNORE_PATHS
wic: Pass canonicalized paths in PSEUDO_IGNORE_PATHS
Ricardo Ribalda Delgado (4):
wic: Fix permissions when using exclude or include path
wic: Fix multi images .wks with bitbake
wic: Avoid creating invalid pseudo directory
wic: Add --change-directory argument
Richard Purdie (23):
pseudo: Switch to oe-core branch in git repo
pseudo: merge in fixes for setfacl issue
pseudo: Update to add OFC fcntl lock updates
pseudo: Ignore mismatched inodes from the db
pseudo: Add support for ignoring paths from the pseudo DB
pseudo: Abort on mismatch patch
psuedo: Add tracking of linked files for fds
pseudo: Fix xattr segfault
pseudo: Add may unlink patch
pseudo: Add pathfix patch
base/bitbake.conf: Enable pseudo path filtering
wic: Handle new PSEUDO_IGNORE_PATHS variable
pseudo: Fix statx function usage
bitbake.conf: Extend PSEUDO_IGNORE_PATHS to ${COREBASE}/meta
abi_version,sanity: Tell users TMPDIR must be clean after pseudo
changes
pseudo: Update to account for patches merged on branch
pseudo: Upgrade to include mkostemp64 wrapper
oeqa/selftest/runtime_test: Exclude gpg directory from pseudo database
uninative: Don't use single sstate for pseudo-native
pseudo: Drop patches merged into upstream branch
bitbake.conf: Add /run/ to PSEUDO_IGNORE_PATHS
pseudo: Add lchmod wrapper
pseudo: Update for arm host and memleak fixes/cleanup
Tomasz Dziendzielski (1):
pseudo: Update to print PSEUDO_LOGFILE in abort message on path
mismatches
meta-selftest/lib/pseudo_pyc_test1.py | 1 +
meta-selftest/lib/pseudo_pyc_test2.py | 1 +
.../pseudo-pyc-test/pseudo-pyc-test.bb | 15 ++
meta/classes/archiver.bbclass | 2 +-
meta/classes/base.bbclass | 6 +
meta/classes/distutils3.bbclass | 10 +-
meta/classes/image_types_wic.bbclass | 20 ++-
meta/classes/license.bbclass | 1 +
meta/classes/populate_sdk_base.bbclass | 2 +
meta/classes/sanity.bbclass | 3 +
meta/classes/sstate.bbclass | 4 +
meta/conf/abi_version.conf | 2 +-
meta/conf/bitbake.conf | 13 +-
meta/lib/oe/path.py | 21 +++
meta/lib/oe/sstatesig.py | 4 +-
meta/lib/oeqa/selftest/cases/pseudo.py | 27 ++++
meta/lib/oeqa/selftest/cases/runtime_test.py | 1 +
.../pseudo/files/0001-Add-statx.patch | 106 --------------
...001-maketables-wrappers-use-Python-3.patch | 34 -----
...ixup-remove-files-that-do-not-exist-.patch | 49 -------
.../0001-pseudo_ipc.h-Fix-enum-typedef.patch | 31 ----
...1-realpath.c-Remove-trailing-slashes.patch | 57 --------
...xattr-adjust-for-attr-2.4.48-release.patch | 48 ------
.../pseudo/files/moreretries.patch | 19 ---
.../pseudo/files/seccomp.patch | 137 ------------------
.../pseudo/files/toomanyfiles.patch | 71 ---------
.../pseudo/files/xattr_version.patch | 54 -------
meta/recipes-devtools/pseudo/pseudo_git.bb | 14 +-
meta/recipes-devtools/tcltk/tcl_8.6.10.bb | 1 +
scripts/lib/wic/help.py | 6 +
scripts/lib/wic/ksparser.py | 1 +
scripts/lib/wic/misc.py | 7 +-
scripts/lib/wic/partition.py | 66 ++++++---
scripts/lib/wic/plugins/imager/direct.py | 48 +++---
scripts/lib/wic/plugins/source/rootfs.py | 85 +++++++++--
scripts/postinst-intercepts/update_font_cache | 2 +
scripts/wic | 2 +
37 files changed, 281 insertions(+), 690 deletions(-)
create mode 100644 meta-selftest/lib/pseudo_pyc_test1.py
create mode 100644 meta-selftest/lib/pseudo_pyc_test2.py
create mode 100644 meta-selftest/recipes-test/pseudo-pyc-test/pseudo-pyc-test.bb
create mode 100644 meta/lib/oeqa/selftest/cases/pseudo.py
delete mode 100644 meta/recipes-devtools/pseudo/files/0001-Add-statx.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/0001-maketables-wrappers-use-Python-3.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/0001-pseudo-On-a-DB-fixup-remove-files-that-do-not-exist-.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/0001-pseudo_ipc.h-Fix-enum-typedef.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/0001-realpath.c-Remove-trailing-slashes.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/0006-xattr-adjust-for-attr-2.4.48-release.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/moreretries.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/seccomp.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/toomanyfiles.patch
delete mode 100644 meta/recipes-devtools/pseudo/files/xattr_version.patch
--
2.25.1
next reply other threads:[~2021-01-26 14:42 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 14:41 Steve Sakoman [this message]
2021-01-26 14:41 ` [OE-core][dunfell V3 01/46] pseudo: Switch to oe-core branch in git repo Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 02/46] pseudo: merge in fixes for setfacl issue Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 03/46] pseudo: Update to add OFC fcntl lock updates Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 04/46] pseudo: fix renaming to self Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 05/46] pseudo: Ignore mismatched inodes from the db Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 06/46] pseudo: Add support for ignoring paths from the pseudo DB Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 07/46] pseudo: Abort on mismatch patch Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 08/46] psuedo: Add tracking of linked files for fds Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 09/46] pseudo: Fix xattr segfault Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 10/46] pseudo: Add may unlink patch Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 11/46] pseudo: Add pathfix patch Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 12/46] base/bitbake.conf: Enable pseudo path filtering Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 13/46] wic: Fix permissions when using exclude or include path Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 14/46] wic: Fix multi images .wks with bitbake Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 15/46] wic: Avoid creating invalid pseudo directory Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 16/46] wic: Handle new PSEUDO_IGNORE_PATHS variable Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 17/46] pseudo: Fix statx function usage Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 18/46] bitbake.conf: Extend PSEUDO_IGNORE_PATHS to ${COREBASE}/meta Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 19/46] abi_version,sanity: Tell users TMPDIR must be clean after pseudo changes Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 20/46] pseudo: Update to account for patches merged on branch Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 21/46] pseudo: Upgrade to include mkostemp64 wrapper Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 22/46] base.bbclass: use os.path.normpath instead of just comparing WORKDIR and S as strings Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 23/46] oeqa/selftest/runtime_test: Exclude gpg directory from pseudo database Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 24/46] tcl: adapt to potential pseudo changes Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 25/46] bitbake.conf: Exclude ${CCACHE_DIR} from pseudo database Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 26/46] uninative: Don't use single sstate for pseudo-native Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 27/46] pseudo: Simplify pseudo_client_ignore_path_chroot() Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 28/46] pseudo: Update to print PSEUDO_LOGFILE in abort message on path mismatches Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 29/46] distutils3: allow setup.py to be run from a different directory to ${S} Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 30/46] pseudo: Drop patches merged into upstream branch Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 31/46] lib/oe/path: Add canonicalize() Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 32/46] bitbake.conf: Canonicalize paths in PSEUDO_IGNORE_PATHS Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 33/46] wic: Pass canonicalized " Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 34/46] bitbake.conf: Prevent pyc file generation in pseudo context Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 35/46] license.bbclass: Add COMMON_LICENSE_DIR and LICENSE_PATH dirs to PSEUDO_IGNORE_PATHS Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 36/46] bitbake.conf: Add /run/ " Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 37/46] pseudo: Add lchmod wrapper Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 38/46] pseudo: Update for arm host and memleak fixes/cleanup Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 39/46] wic: Add workdir argument Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 40/46] wic: Allow exec_native_cmd to run HOSTTOOLS Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 41/46] wic: Ensure internal workdir is not reused Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 42/46] image_types_wic: Move wic working directory Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 43/46] wic: Update pseudo db when excluding content from rootfs Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 44/46] wic: Add --change-directory argument Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 45/46] wic: Copy rootfs dir if fstab needs updating Steve Sakoman
2021-01-26 14:41 ` [OE-core][dunfell V3 46/46] wic: Optimise fstab modification for ext2/3/4 and msdos partitions Steve Sakoman
2021-01-26 14:57 ` [OE-core][dunfell V3 00/46] Patch review - pseudo file mode corruption fix V3 Paul Barker
2021-01-26 15:08 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1611671734.git.steve@sakoman.com \
--to=steve@sakoman.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox