From: Anders Heimer <anders.heimer@est.tech>
To: openembedded-core@lists.openembedded.org
Cc: Anders Heimer <anders.heimer@est.tech>
Subject: [PATCH v2 0/9] execute patch commands without an implicit shell
Date: Wed, 24 Jun 2026 14:43:58 +0200 [thread overview]
Message-ID: <cover.1782304923.git.anders.heimer@est.tech> (raw)
Continue the shell=True cleanup in oe.patch.
Run runcmd() argument lists directly instead of joining them into an
implicit shell command string.
This series converts the non test runcmd() callers that invoked it with
-sh.
The series also replaces the cat-to-patch pipeline with patch -i,
removes the obsolete PATCHFILE assignment, converts GitApplyTree
commands to argv lists, and keeps manual-resolution commands as argv
lists.
oelib tests cover argv handling and error reporting, GitApplyTree
patch-name preservation, fallback commit metadata, and run=False
command generation without repository side effects.
Changes in v2:
- Accept both valid Git `%aI` representations of UTC, `Z` and `+00:00`,
in the fallback metadata test
Anders Heimer (9):
oe/patch: drop shell=True from runcmd
oeqa/oelib: add runcmd tests
oe/patch: convert simple runcmd shell callers
oe/patch: avoid shell pipeline in _applypatch
oe/patch: remove obsolete PATCHFILE assignment
oeqa/oelib: test GitApplyTree patch names
oe/patch: pass GitApplyTree commands as argv lists
oe/patch: return manual-resolution commands as argv lists
oeqa/oelib: test patch command argv handling
meta/lib/oe/patch.py | 131 +++++----
meta/lib/oeqa/selftest/cases/oelib/patch.py | 282 ++++++++++++++++++++
scripts/lib/devtool/upgrade.py | 2 +-
3 files changed, 355 insertions(+), 60 deletions(-)
create mode 100644 meta/lib/oeqa/selftest/cases/oelib/patch.py
next reply other threads:[~2026-06-24 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:43 Anders Heimer [this message]
2026-06-24 12:43 ` [PATCH v2 1/9] oe/patch: drop shell=True from runcmd Anders Heimer
2026-06-24 12:44 ` [PATCH v2 2/9] oeqa/oelib: add runcmd tests Anders Heimer
2026-06-24 12:44 ` [PATCH v2 3/9] oe/patch: convert simple runcmd shell callers Anders Heimer
2026-06-24 12:44 ` [PATCH v2 4/9] oe/patch: avoid shell pipeline in _applypatch Anders Heimer
2026-06-24 12:44 ` [PATCH v2 5/9] oe/patch: remove obsolete PATCHFILE assignment Anders Heimer
2026-06-24 12:44 ` [PATCH v2 6/9] oeqa/oelib: test GitApplyTree patch names Anders Heimer
2026-06-24 12:44 ` [PATCH v2 7/9] oe/patch: pass GitApplyTree commands as argv lists Anders Heimer
2026-06-24 12:44 ` [PATCH v2 8/9] oe/patch: return manual-resolution " Anders Heimer
2026-06-24 12:44 ` [PATCH v2 9/9] oeqa/oelib: test patch command argv handling Anders Heimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1782304923.git.anders.heimer@est.tech \
--to=anders.heimer@est.tech \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox