From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by mail.openembedded.org (Postfix) with ESMTP id A0DEB788D0 for ; Sun, 7 Jan 2018 19:38:24 +0000 (UTC) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3zF7xF3MZxz1qrN3; Sun, 7 Jan 2018 20:38:25 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3zF7xF382kz26T1p; Sun, 7 Jan 2018 20:38:25 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Akx4Krd4T-Zu; Sun, 7 Jan 2018 20:38:24 +0100 (CET) X-Auth-Info: Edmy2OciIBN0Rdkqqdlpo12w67kHLORyqK07TTWlY5c= Received: from [IPv6:::1] (unknown [195.140.253.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 7 Jan 2018 20:38:24 +0100 (CET) To: Alexander Kanavin , openembedded-core@lists.openembedded.org References: <20180107161920.30937-1-marex@denx.de> <3cdba2e1-94df-32fd-0138-a6fa533ec165@linux.intel.com> <233b2ff5-22a9-f378-98d9-fb833f5cc848@denx.de> <878f3830-3b43-cdd4-aa06-e237db4d0af0@linux.intel.com> From: Marek Vasut Message-ID: Date: Sun, 7 Jan 2018 20:37:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <878f3830-3b43-cdd4-aa06-e237db4d0af0@linux.intel.com> Subject: Re: [PATCH 1/2] xenomai: Add xenomai recipe X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jan 2018 19:38:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/07/2018 08:27 PM, Alexander Kanavin wrote: > On 01/07/2018 07:55 PM, Marek Vasut wrote: >>>> Add recipe for the xenomai. This recipe is used twice, once to build >>>> the xenomai userspace components and again to patch the kernel with >>>> the cobalt core. Therefore, the xenomai sources are installed into >>>> work-shared rather then work to make them accessible to the kernel >>>> recipe, which triggers the patching. >>> >>> What is xenomai? What is a 'cobalt core'? What do they do and who would >>> want to use them? Please do explain that in the commit message. >> >> I guess the link in the xenomai recipe explains it, details are here: >> http://xenomai.org/installing-xenomai-3-x/ > > I need to clarify: all of these questions need to be answered in the > context of oe-core. Essentially, you need to explain why the recipe > should be in oe-core and not in its own layer. Same rationale as for having linux-*-rt with preempt-rt patch. >>>> +SUMMARY = "Xenomai 3 userspace libraries" >>>> +DESCRIPTION = "Xenomai 3 userspace libraries" >>> >>> ... and here - description cannot be the same as the summary. >> >> So do I remove one of them or what's the difference really ? > > Same as the difference between commit summary and commit message. > Description usually spans several lines, and provides fully formed > sentences that explain what the software provided by the recipe does. > > Also, an update to maintainers.inc would be appreciated, when adding new > recipes. Fine -- Best regards, Marek Vasut