public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: "Vincent Stehlé" <vincent.stehle@arm.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH pseudo] Fix build with gcc 10
Date: Fri, 20 Nov 2020 17:24:31 +0000	[thread overview]
Message-ID: <d042ad2eb586ce7e546386462c3a63d6b62463c7.camel@linuxfoundation.org> (raw)
In-Reply-To: <20201120163853.13737-1-vincent.stehle@arm.com>

On Fri, 2020-11-20 at 17:38 +0100, Vincent Stehlé wrote:
> Add a missing typedef in front of the pseudo_access_t definition.
> Otherwise
> pseudo_access_t ends up being a global enum, defined each time
> pseudo_ipc.h
> is included.
> 
> This fixes the following link time error with gcc 10:
> 
>   multiple definition of `pseudo_access_t'
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
> ---
>  pseudo_ipc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pseudo_ipc.h b/pseudo_ipc.h
> index caeae5c..d945257 100644
> --- a/pseudo_ipc.h
> +++ b/pseudo_ipc.h
> @@ -29,7 +29,7 @@ typedef struct {
>  	char path[];
>  } pseudo_msg_t;
>  
> -enum {
> +typedef enum {
>  	PSA_EXEC = 1,
>  	PSA_WRITE = (PSA_EXEC << 1),
>  	PSA_READ = (PSA_WRITE << 1),

I think we already have this in the pseudo branch we use for OE?

http://git.yoctoproject.org/cgit.cgi/pseudo/commit/pseudo_ipc.h?h=oe-core&id=a44361b8d3fbf5fc40cd87b599caeb380454efbe

Cheers,

Richard


  reply	other threads:[~2020-11-20 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 16:38 [PATCH pseudo] Fix build with gcc 10 vincent.stehle
2020-11-20 17:24 ` Richard Purdie [this message]
2020-11-20 17:28   ` [OE-core] " Vincent Stehlé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d042ad2eb586ce7e546386462c3a63d6b62463c7.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=vincent.stehle@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox