RE: [oe-core][PATCHv2] packagegroup-base.bb: remove wpa_supplicant preset from packagegroup-base-wifi

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Markus Volk
> Sent: den 28 augusti 2022 18:59
> To: openembedded-core@lists.openembedded.org
> Cc: Markus Volk <f_l_k@t-online.de>
> Subject: [oe-core][PATCHv2] packagegroup-base.bb: remove wpa_supplicant preset from packagegroup-base-wifi
> 
> This removes wpa_supplicant from packagegroup-base-wifi so that the
> decision of which wireless daemon to use can be made within the recipes.
> Possible choices would be wpa_supplicant or iwd.
> 
> iwd is a wireless daemon written by intel and supported by all major network managers.
> It can be run in standalone mode and configured with 'iwctl' from the terminal, and
> with 'iwgtk' or 'iwdgui' from the gui. It can also work as a wpa_supplicant drop-in
> replacement for network-manager, connman or systemd-networkd.
> 
> iwd makes heavy use of the kernel api, so it is not portable but does not need
> additional external libraries like openssl.
> 
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
>  meta/recipes-core/packagegroups/packagegroup-base.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
> index 7489ef61b0..a70a107dac 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> @@ -271,7 +271,7 @@ SUMMARY:packagegroup-base-wifi = "WiFi support"
>  RDEPENDS:packagegroup-base-wifi = "\
>      iw \
>      wireless-regdb-static \
> -    wpa-supplicant"
> +"

Rather than removing wpa-supplicant, which breaks backwards 
compatibility and expectations, wouldn't it make more sense to
introduce a variable for the wireless service, and default it 
to wpa-supplicant. Then there is no breakage for those who 
expect packagegroup-base-wifi to pull in wpa-supplicant, but 
those who want to use iwd can easily change the configuration 
in their distros. 

> 
>  RRECOMMENDS:packagegroup-base-wifi = "\
>      ${@bb.utils.contains('COMBINED_FEATURES', 'usbhost', 'kernel-module-zd1211rw', '',d)} \
> --
> 2.34.1

//Peter