Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	openembedded-core@lists.openembedded.org
Cc: Alexander Kanavin <alex@linutronix.de>
Subject: Re: [OE-core] [PATCH 33/36] expect: do not install examples, drop related patch
Date: Wed, 17 Nov 2021 11:05:17 -0800	[thread overview]
Message-ID: <d262e394-c2b6-de95-7a08-ea2f7afa10f5@gmail.com> (raw)
In-Reply-To: <20211117153525.257146-33-alex@linutronix.de>



On 11/17/21 7:35 AM, Alexander Kanavin wrote:
> There is really no reason to install them; this was done
> in the original recipe submission for unexplained reasons.

yes perhaps as part of main PN package its not but as a separate package 
something like PN-examples or some such it will be better

> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>   .../expect/expect/01-example-shebang.patch    | 144 ------------------
>   meta/recipes-devtools/expect/expect_5.45.4.bb |   2 -
>   2 files changed, 146 deletions(-)
>   delete mode 100644 meta/recipes-devtools/expect/expect/01-example-shebang.patch
> 
> diff --git a/meta/recipes-devtools/expect/expect/01-example-shebang.patch b/meta/recipes-devtools/expect/expect/01-example-shebang.patch
> deleted file mode 100644
> index 8597f31387..0000000000
> --- a/meta/recipes-devtools/expect/expect/01-example-shebang.patch
> +++ /dev/null
> @@ -1,144 +0,0 @@
> -Author: Mike Markley <mike@markley.org>
> -Author: Sergei Golovan <sgolovan@debian.org>
> -Description: Fixes shebangs in examples (Closes: #152367).
> -
> -Backported from Debian
> -
> -Upstream-Status: Pending
> -Index: expect5.45/example/beer.exp
> -===================================================================
> ---- expect5.45.orig/example/beer.exp	2006-01-25 13:51:39.000000000 -0800
> -+++ expect5.45/example/beer.exp	2013-11-01 17:35:19.817318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expect -f
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> - # 99 bottles of beer on the wall, Expect-style
> - # Author: Don Libes <libes@nist.gov>
> -Index: expect5.45/example/expectd.proto
> -===================================================================
> ---- expect5.45.orig/example/expectd.proto	2010-07-02 09:03:31.000000000 -0700
> -+++ expect5.45/example/expectd.proto	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,10 @@
> --#!/depot/tcl/src/expect/e --
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -+
> - # Description: Simple fragment to begin a telnet daemon
> - # For more information, see Chapter 17 of "Exploring Expect"
> - # Author: Don Libes, NIST
> -Index: expect5.45/example/irsh
> -===================================================================
> ---- expect5.45.orig/example/irsh	2010-07-02 09:03:31.000000000 -0700
> -+++ expect5.45/example/irsh	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expect --
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> - # Do rsh interactively.  For example, consider the following command:
> - #    rsh <remote> ls -l "|" more
> -Index: expect5.45/example/passwd.cgi
> -===================================================================
> ---- expect5.45.orig/example/passwd.cgi	2000-01-06 15:22:07.000000000 -0800
> -+++ expect5.45/example/passwd.cgi	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expect --
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> - # This is a CGI script to process requests created by the accompanying
> - # passwd.html form.  This script is pretty basic, although it is
> -Index: expect5.45/example/passwdprompt
> -===================================================================
> ---- expect5.45.orig/example/passwdprompt	2003-09-05 12:01:59.000000000 -0700
> -+++ expect5.45/example/passwdprompt	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expect
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> - # This script prompts for a passwd from stdin while echoing *'s
> -
> -Index: expect5.45/example/reprompt
> -===================================================================
> ---- expect5.45.orig/example/reprompt	2000-01-06 15:22:07.000000000 -0800
> -+++ expect5.45/example/reprompt	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expect --
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> - # Name: reprompt
> - # Description: reprompt every so often until user enters something
> -Index: expect5.45/example/term_expect
> -===================================================================
> ---- expect5.45.orig/example/term_expect	2005-02-15 10:11:31.000000000 -0800
> -+++ expect5.45/example/term_expect	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expectk
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec wish "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> - # Name: tkterm - terminal emulator using Expect and Tk text widget, v3.0
> - # Author: Don Libes, July '94
> -Index: expect5.45/example/vrfy
> -===================================================================
> ---- expect5.45.orig/example/vrfy	2010-07-02 09:03:31.000000000 -0700
> -+++ expect5.45/example/vrfy	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,9 @@
> --#!/depot/path/expect -f
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -
> -
> - # separate address into user and host
> -Index: expect5.45/example/xrlogin
> -===================================================================
> ---- expect5.45.orig/example/xrlogin	2000-01-06 15:22:08.000000000 -0800
> -+++ expect5.45/example/xrlogin	2013-11-01 17:35:19.821318341 -0700
> -@@ -1,4 +1,10 @@
> --#!/depot/path/expect --
> -+#!/bin/sh
> -+# -*- tcl -*-
> -+# The next line is executed by /bin/sh, but not tcl \
> -+exec tclsh "$0" ${1+"$@"}
> -+
> -+package require Expect
> -+
> - # xrlogin - rlogin but with current DISPLAY
> - #
> - # You can extend this idea to save any arbitrary information across rlogin
> diff --git a/meta/recipes-devtools/expect/expect_5.45.4.bb b/meta/recipes-devtools/expect/expect_5.45.4.bb
> index e27b0d9d71..4214ab0f27 100644
> --- a/meta/recipes-devtools/expect/expect_5.45.4.bb
> +++ b/meta/recipes-devtools/expect/expect_5.45.4.bb
> @@ -21,7 +21,6 @@ inherit autotools update-alternatives
>   SRC_URI = "${SOURCEFORGE_MIRROR}/expect/Expect/${PV}/${BPN}${PV}.tar.gz \
>              file://0001-configure.in.patch \
>              file://0002-tcl.m4.patch \
> -           file://01-example-shebang.patch \
>              file://0001-expect-install-scripts-without-using-the-fixline1-tc.patch \
>              file://0001-Resolve-string-formatting-issues.patch \
>              file://0001-expect-Fix-segfaults-if-Tcl-is-built-with-stubs-and-.patch \
> @@ -39,7 +38,6 @@ do_install:append() {
>   	install -d ${D}${libdir}
>           install -m 0755 ${D}${libdir}/expect${PV}/libexpect*.so   ${D}${libdir}/
>           install -m 0755 ${S}/fixline1           ${D}${libdir}/expect${PV}/
> -        install -m 0755 ${S}/example/*          ${D}${libdir}/expect${PV}/
>           rm ${D}${libdir}/expect${PV}/libexpect*.so
>           sed -e 's|$dir|${libdir}|' -i ${D}${libdir}/expect${PV}/pkgIndex.tcl
>   }
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#158428): https://lists.openembedded.org/g/openembedded-core/message/158428
> Mute This Topic: https://lists.openembedded.org/mt/87122010/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


  reply	other threads:[~2021-11-17 19:05 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 15:34 [PATCH 01/36] ovmf: submit patch upstream Alexander Kanavin
2021-11-17 15:34 ` [PATCH 02/36] groff: mark patch as non-upstreamable Alexander Kanavin
2021-11-19 11:15   ` [OE-core] " Richard Purdie
2021-11-19 11:33     ` Alexander Kanavin
     [not found]     ` <16B8EF5BF2691601.30231@lists.openembedded.org>
2021-11-19 12:08       ` Alexander Kanavin
2021-11-19 12:29         ` Richard Purdie
2021-11-19 14:09           ` Alexander Kanavin
2021-11-17 15:34 ` [PATCH 03/36] logrotate: add a link to upstream review for one of the patch Alexander Kanavin
2021-11-17 15:34 ` [PATCH 04/36] weston: submit patch upstream Alexander Kanavin
2021-11-17 15:34 ` [PATCH 05/36] db: mark all patches as non-upstreamable Alexander Kanavin
2021-11-17 15:34 ` [PATCH 06/36] unzip/zip: " Alexander Kanavin
2021-11-17 15:34 ` [PATCH 07/36] automake: update 1.16.3 -> 1.16.5 Alexander Kanavin
2021-11-17 15:34 ` [PATCH 08/36] libunistring: address automake 1.16.5 failures Alexander Kanavin
2021-11-17 15:34 ` [PATCH 09/36] gettext: " Alexander Kanavin
2021-11-17 15:34 ` [PATCH 10/36] ccache: upgrade 4.4.2 -> 4.5 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 11/36] python3-hypothesis: upgrade 6.24.2 -> 6.24.3 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 12/36] python3-pyparsing: upgrade 3.0.5 -> 3.0.6 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 13/36] asciidoc: upgrade 10.0.1 -> 10.0.2 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 14/36] libpipeline: upgrade 1.5.3 -> 1.5.4 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 15/36] piglit: upgrade to latest revision Alexander Kanavin
2021-11-17 15:35 ` [PATCH 16/36] diffoscope: upgrade 190 -> 192 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 17/36] systemd: upgrade 249.5 -> 249.6 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 18/36] xwayland: upgrade 21.1.2 -> 21.1.3 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 19/36] curl: update 7.79.1 -> 7.80.0 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 20/36] librsvg: update 2.52.3 -> 2.52.4 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 21/36] librstd-rs: submit patches upstream Alexander Kanavin
2021-11-17 15:35 ` [PATCH 22/36] elfutils: update 0.185 -> 0.186 Alexander Kanavin
2021-11-17 17:15   ` Khem Raj
2021-11-17 17:32     ` Alexander Kanavin
2021-11-17 17:43       ` Khem Raj
     [not found]       ` <YZVT+eDIX8zbnOHA@wildebeest.org>
2021-11-17 19:17         ` Khem Raj
2021-11-17 19:43           ` Alexander Kanavin
2021-11-17 15:35 ` [PATCH 23/36] libsamplerate0: update 0.1.9 -> 0.2.2 Alexander Kanavin
2021-11-17 15:35 ` [PATCH 24/36] patches: correct whitespace/spelling for Upstream-Status tags Alexander Kanavin
2021-11-17 15:35 ` [PATCH 25/36] autoconf: add missing Upstream-Status to patches Alexander Kanavin
2021-11-17 15:35 ` [PATCH 26/36] libxml2: add missing Upstream-Status tag Alexander Kanavin
2021-11-17 15:35 ` [PATCH 27/36] unfs3: " Alexander Kanavin
2021-11-17 15:35 ` [PATCH 28/36] libnl: " Alexander Kanavin
2021-11-17 15:35 ` [PATCH 29/36] kea: add missing Upstream-Status to a patch Alexander Kanavin
2021-11-17 15:35 ` [PATCH 30/36] rust-hello-world: " Alexander Kanavin
2021-11-17 15:35 ` [PATCH 31/36] numactl: " Alexander Kanavin
2021-11-17 15:35 ` [PATCH 32/36] insane.bbclass: add a check that Upstream-Status patch tag is present and correctly formed Alexander Kanavin
2021-11-17 15:35 ` [PATCH 33/36] expect: do not install examples, drop related patch Alexander Kanavin
2021-11-17 19:05   ` Khem Raj [this message]
2021-11-17 22:00     ` [OE-core] " Alexander Kanavin
2021-11-17 23:09       ` Khem Raj
2021-11-17 15:35 ` [PATCH 34/36] busybox: drop 0001-Use-CC-when-linking-instead-of-LD-and-use-CFLAGS-and.patch Alexander Kanavin
2021-11-17 20:43   ` [OE-core] " Andre McCurdy
2021-11-17 22:05     ` Alexander Kanavin
     [not found]     ` <16B874A872BAAE14.8846@lists.openembedded.org>
2021-11-18 10:32       ` Alexander Kanavin
2021-11-18 23:14         ` Andre McCurdy
2021-11-19  8:17           ` Alexander Kanavin
2021-11-19  8:56             ` Andre McCurdy
2021-11-17 15:35 ` [PATCH 35/36] slang: mark patch as inappropriate for upstream submission Alexander Kanavin
2021-11-17 15:35 ` [PATCH 36/36] librsvg: submit system-deps patch upstream Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d262e394-c2b6-de95-7a08-ea2f7afa10f5@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=alex.kanavin@gmail.com \
    --cc=alex@linutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox