Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] dpkg: upgrade to 1.18.15
Date: Fri, 16 Dec 2016 15:17:16 +0200	[thread overview]
Message-ID: <d31cb432-562f-bcca-76d9-b15ec7e11bcb@linux.intel.com> (raw)
In-Reply-To: <1481852668-23967-1-git-send-email-edwin.plauchu.camacho@linux.intel.com>

On 12/16/2016 03:44 AM, Edwin Plauchu wrote:
> From: Edwin Plauchu <edwin.plauchu.camacho@intel.com>
>
> Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho@linux.intel.com>

In addition to file rename detection (see Jussi's mail), you need to 
explain in the commit message the changes that you made.

Specifically:

>  ...tinsts-expect-D-to-be-set-when-running-in.patch | 30 +++++++-------

Was this rebased? Did you have to also modify the code and how?

>  .../dpkg/dpkg/add_armeb_triplet_entry.patch        | 46 ----------------------
>  .../dpkg/dpkg/add_armeb_tuple_entry.patch          | 46 ++++++++++++++++++++++

Is this the same patch or two different patches? Why did triplet change 
to tuple?

> -           file://0006-add-musleabi-to-known-target-tripets.patch \

What happened to this patch? You removed it from the recipe, but didn't 
remove the file and didn't explain why.


Alex


      reply	other threads:[~2016-12-16 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  1:44 [PATCH] dpkg: upgrade to 1.18.15 Edwin Plauchu
2016-12-16 13:17 ` Alexander Kanavin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d31cb432-562f-bcca-76d9-b15ec7e11bcb@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox