public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Ryan Eatmon <reatmon@ti.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][PATCH] linux-firmware: Move all firmware into sub-packages
Date: Tue, 7 Oct 2025 07:54:58 -0500	[thread overview]
Message-ID: <d395d3a2-4467-4e62-beef-f7b5ab973e89@ti.com> (raw)
In-Reply-To: <186C362D6E62D57C.5353@lists.openembedded.org>



On 10/7/2025 7:45 AM, Ryan Eatmon via lists.openembedded.org wrote:
> 
> 
> On 10/7/2025 2:34 AM, Mathieu Dubois-Briand wrote:
>> On Mon Oct 6, 2025 at 7:08 PM CEST, Ryan Eatmon via 
>> lists.openembedded.org wrote:
>>> A lot of the firmware has already been broken out into sub-packages, but
>>> a good number were still lingering in the base linux-firmware package.
>>>
>>> This patch does two things:
>>>
>>> 1) Move all of the remaining firmware into sub-packages based on the
>>> driver name in the WHENCE file or into existing sub-packages where a
>>> file or two were missed.
>>>
>>> 2) Create a new REMOVE_UNLICENSED variable and do_install() logic to
>>> allow for marking certain firmware files as something to remove and not
>>> package up.  The intention is that in the WHENCE file, a number of
>>> firmware files have no license information or very questionable
>>> declarations as to what the license is for the firmware.
>>>
>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>>> ---
>>
>> Hi Ryan,
>>
>> Thanks for your patch.
>>
>> It looks like some files are not shipped correctly:
>>
>> ERROR: linux-firmware-1_20250917-r0 do_package: QA Issue: linux- 
>> firmware: Files/directories were installed but not shipped in any 
>> package:
>>    /lib/firmware/ess
>>    /lib/firmware/ttusb-budget
>>    /lib/firmware/emi62
>>    /lib/firmware/myricom
>>    /lib/firmware/sun
>>    /lib/firmware/yamaha
>>    /lib/firmware/korg
>>    /lib/firmware/vicam
>>    /lib/firmware/acenic
>>    /lib/firmware/yam
>>    /lib/firmware/qcom/sa8775p/LEMANS-EVK-tplg.bin
>> Please set FILES such that these items are packaged. Alternatively if 
>> they are unneeded, avoid installing them or delete them within 
>> do_install.
>>
>> https://autobuilder.yoctoproject.org/valkyrie/#/builders/4/builds/2542
>>
>> Can you fix it please?
> 
> That is odd.  I don't get that error on my builds.  All of those files 
> should have been removed by the new REMOVE_UNLICENSED feature in the 
> recipe.  I'll take a look.

I actually added some "debug" output to the do_install code.  Can you 
get the log.do_install file for that run?  My company's firewall setup 
is blocking the WebSockets stuff that the autobuilder site uses, so if 
it is available there I apologize.  Working with them to address it.


> 
>> Thanks,
>> Mathieu
>>
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#224530): https://lists.openembedded.org/g/openembedded-core/message/224530
> Mute This Topic: https://lists.openembedded.org/mt/115621118/6551054
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS



  parent reply	other threads:[~2025-10-07 12:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 17:08 [OE-core][PATCH] linux-firmware: Move all firmware into sub-packages Ryan Eatmon
2025-10-07  7:34 ` Mathieu Dubois-Briand
2025-10-07 12:45   ` Ryan Eatmon
     [not found]   ` <186C362D6E62D57C.5353@lists.openembedded.org>
2025-10-07 12:54     ` Ryan Eatmon [this message]
2025-10-07 14:51       ` Mathieu Dubois-Briand
2025-10-07 15:15         ` Ryan Eatmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d395d3a2-4467-4e62-beef-f7b5ab973e89@ti.com \
    --to=reatmon@ti.com \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox