From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: mikko.rapeli@linaro.org, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] uki.bbclass: fix UKI_DEVICETREE
Date: Fri, 27 Mar 2026 14:54:48 +0000 [thread overview]
Message-ID: <d3fe353d964e4dfce0bc4c47f104fc8a9fa2a863.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260325104830.23519-1-mikko.rapeli@linaro.org>
On Wed, 2026-03-25 at 12:48 +0200, Mikko Rapeli via lists.openembedded.org wrote:
> UKI_DEVICETREE needs to be empty when KERNEL_DEVICETREE
> is not set. Fixes genericarm64 uki image builds:
>
> ERROR: ERROR: cannot find /home/builder/src/core/build/tmp/deploy/images/genericarm64/${KERNEL_DEVICETREE}.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
> meta/classes-recipe/uki.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/uki.bbclass b/meta/classes-recipe/uki.bbclass
> index 326697a06660..a6a88240f798 100644
> --- a/meta/classes-recipe/uki.bbclass
> +++ b/meta/classes-recipe/uki.bbclass
> @@ -80,7 +80,7 @@ UKI_CONFIG_FILE ?= "${UNPACKDIR}/uki.conf"
> UKI_FILENAME ?= "uki.efi"
> UKI_KERNEL_FILENAME ?= "${KERNEL_IMAGETYPE}"
> UKI_CMDLINE ?= "rootwait root=LABEL=root"
> -UKI_DEVICETREE ?= "${KERNEL_DEVICETREE}"
> +UKI_DEVICETREE ?= "${@ d.getVar('KERNEL_DEVICETREE') or ''}"
> # secure boot keys and cert, needs sbsign-tools-native (meta-secure-core)
> #UKI_SB_KEY ?= ""
> #UKI_SB_CERT ?= ""
Is there a reason not to do:
KERNEL_DEVICETREE ??= ""
instead?
Inline python isn't great...
Cheers,
Richard
next prev parent reply other threads:[~2026-03-27 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 10:48 [PATCH] uki.bbclass: fix UKI_DEVICETREE Mikko Rapeli
2026-03-27 14:54 ` Richard Purdie [this message]
2026-03-28 10:45 ` [OE-core] " Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3fe353d964e4dfce0bc4c47f104fc8a9fa2a863.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mikko.rapeli@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox