Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Böszörményi Zoltán" <zboszor@gmail.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] gitsm:// question
Date: Wed, 18 Oct 2023 15:25:04 +0200	[thread overview]
Message-ID: <d466e4c6-20bf-42e2-8342-c058fca4aea2@gmail.com> (raw)
In-Reply-To: <CA+chaQcLsDyXMFRtpUdH6yCWCXuShSytFyoqRZ_5F8Ton4HfzA@mail.gmail.com>

Thanks, I will try it.

2023. 10. 18. 15:16 keltezéssel, Martin Jansa írta:
> Just add the name to pytorch repo url and use only that in SRCREV_FORMAT, you probably 
> don't care about representing the other repos in SRCPV if you're updating them only 
> together with main pytorch update.
>
> On Wed, Oct 18, 2023 at 3:05 PM Zoltan Boszormenyi <zboszor@gmail.com> wrote:
>
>     Hi,
>
>     I have a working python3-pytorch recipe which originally used this:
>
>     =======================================================
>     addtask do_git_submodules after do_unpack before do_patch
>
>     do_git_submodules[network] = "1"
>
>     do_git_submodules () {
>              cd ${S}
>              git submodule update --init --recursive
>     }
>     =======================================================
>
>     I would like to replace the above with a series of gitsm:// SRC_URI lines.
>     Here's a subset of submodules that shows the problem I am seeing:
>
>     SRC_URI = " \
>     git://github.com/pytorch/pytorch.git;protocol=https;branch=release/2.1
>     <http://github.com/pytorch/pytorch.git;protocol=https;branch=release/2.1> \
>     ...
>     gitsm://github.com/pytorch/FBGEMM.git;protocol=https;name=fbgemm;nobranch=1;destsuffix=third_party/fbgemm
>     <http://github.com/pytorch/FBGEMM.git;protocol=https;name=fbgemm;nobranch=1;destsuffix=third_party/fbgemm>
>
>     \
>     gitsm://github.com/asmjit/asmjit.git;protocol=https;name=fbgemmasmjit;destsuffix=third_party/fbgemm/third_party/asmjit
>     <http://github.com/asmjit/asmjit.git;protocol=https;name=fbgemmasmjit;destsuffix=third_party/fbgemm/third_party/asmjit>
>
>     \
>     gitsm://github.com/pytorch/cpuinfo.git;protocol=https;name=fbgemmcpuinfo;destsuffix=third_party/fbgemm/third_party/cpuinfo
>     <http://github.com/pytorch/cpuinfo.git;protocol=https;name=fbgemmcpuinfo;destsuffix=third_party/fbgemm/third_party/cpuinfo>
>
>     \
>     gitsm://github.com/NVIDIA/cutlass.git;protocol=https;name=fbgemmcutlass;destsuffix=third_party/fbgemm/third_party/cutlass
>     <http://github.com/NVIDIA/cutlass.git;protocol=https;name=fbgemmcutlass;destsuffix=third_party/fbgemm/third_party/cutlass>
>
>     \
>     gitsm://github.com/google/googletest.git;protocol=https;name=fbgemmgtest;destsuffix=third_party/fbgemm/third_party/googletest
>     <http://github.com/google/googletest.git;protocol=https;name=fbgemmgtest;destsuffix=third_party/fbgemm/third_party/googletest>
>
>     \
>     gitsm://github.com/ROCmSoftwarePlatform/hipify_torch.git;protocol=https;name=fbgemmhiptorch;destsuffix=third_party/fbgemm/third_party/hipify_torch
>     <http://github.com/ROCmSoftwarePlatform/hipify_torch.git;protocol=https;name=fbgemmhiptorch;destsuffix=third_party/fbgemm/third_party/hipify_torch>
>
>     \
>     ...
>     "
>
>     As you can see, there are recursively placed git submodules
>     and do_fetch fails with an error message about SRCREV_FORMAT
>     having to be set.
>
>     The above is a limited subset of the complete list and
>     some of the repositories (like googletest, gloo, glog and pybind11)
>     occurs multiple times as child submodules of upper ones,
>     with different SRCREV values in different leaf submodules.
>
>     I have not found a conclusive example to use SRCREV_FORMAT
>     with git:// + gitsm://
>
>     Can someone enlighten me how to use SRCREV_FORMAT properly
>     for this case? Should I stick to the proven working nonstandard way
>     and just run git submodule update --init --recursive?
>
>     As an easy way out, is there a flag to git:// to process its
>     submodules automatically?
>
>     Thanks in advance,
>     Zoltán Böszörményi
>
>
>     -=-=-=-=-=-=-=-=-=-=-=-
>     Links: You receive all messages sent to this group.
>     View/Reply Online (#189388):
>     https://lists.openembedded.org/g/openembedded-core/message/189388
>     Mute This Topic: https://lists.openembedded.org/mt/102038382/3617156
>     Group Owner: openembedded-core+owner@lists.openembedded.org
>     <mailto:openembedded-core%2Bowner@lists.openembedded.org>
>     Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
>     [martin.jansa@gmail.com]
>     -=-=-=-=-=-=-=-=-=-=-=-
>



  reply	other threads:[~2023-10-18 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 13:04 gitsm:// question Böszörményi Zoltán
2023-10-18 13:16 ` [OE-core] " Martin Jansa
2023-10-18 13:25   ` Böszörményi Zoltán [this message]
2023-10-18 13:28     ` Julien Stephan
2023-10-18 14:12       ` Böszörményi Zoltán
2023-10-18 14:24         ` Julien Stephan
2023-10-18 14:28           ` Martin Jansa
     [not found]   ` <178F367FEBFA030F.14388@lists.openembedded.org>
2023-10-18 16:18     ` Böszörményi Zoltán

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d466e4c6-20bf-42e2-8342-c058fca4aea2@gmail.com \
    --to=zboszor@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox