RE: [OE-core] [honister][PATCH] insane.bbclass: Add a check for directories that are expected to be empty

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Mittal, Anuj <anuj.mittal@intel.com>
> Sent: den 11 november 2021 04:06
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Subject: Re: [OE-core] [honister][PATCH] insane.bbclass: Add a check for
> directories that are expected to be empty
> 
> On Wed, 2021-11-10 at 20:53 +0000, Peter Kjellerstedt wrote:
> > > -----Original Message-----
> > > From: openembedded-core@lists.openembedded.org <openembedded-
> > > core@lists.openembedded.org> On Behalf Of Anuj Mittal
> > > Sent: den 9 november 2021 15:36
> > > To: openembedded-core@lists.openembedded.org; Peter Kjellerstedt
> > > <peter.kjellerstedt@axis.com>
> > > Subject: Re: [OE-core] [honister][PATCH] insane.bbclass: Add a
> > > check for
> > > directories that are expected to be empty
> > >
> > > On Mon, 2021-11-08 at 18:10 +0100, Peter Kjellerstedt wrote:
> > > > From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > >
> > > > The empty-dirs QA check verifies that all directories specified
> > > > in
> > > > QA_EMPTY_DIRS are empty. It is possible to specify why a
> > > > directory is
> > > > expected to be empty by defining
> > > > QA_EMPTY_DIRS_RECOMMENDATION:<path>,
> > > > which will then be included in the error message if the directory
> > > > is
> > > > not empty. If it is not specified for a directory, then "but it
> > > > is
> > > > expected to be empty" will be used.
> > > >
> > > > Change-Id: Ic61019528f4b22f26e42e78125a99666ae27c7f5
> > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > > ---
> > > >
> > > > Compared to the corresponding patch for master, there are two
> > > > differences:
> > > >
> > > > * "/var/volatile" is not added to QA_EMPTY_DIRS by default.
> > > > * "empty-dirs" is added to WARN_QA instead of ERROR_QA.
> > > >
> > > > This should make it safe to add this QA test to Honister without
> > > > introdusing any new QA errors, while still allowing the QA test to be
> > > > activated for those who wants to use it.
> > >
> > > Does it have to be enabled by default?
> >
> > Well, it doesn't have to be enabled. However, without /var/volatile in
> > QA_EMPTY_DIRS, there should be no warnings generated for OE-Core or
> > OpenEmbedded so it should not hurt to have it in WARN_QA.
> 
> Right, but there could be unexpected warnings for other downstream
> layers in release versions.

True, but they would still just be warnings.

> I think we can add the test but only for people to use it if they'd
> like to.

Sure, if you prefer that. Do you want me to send an updated patch, or will 
you take care of it?

> Thanks,
> 
> Anuj

//Peter