From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Wes Lindauer <wesley.lindauer@gmail.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core][PATCH] bitbake.conf: Add resource vars to hash ignore list
Date: Mon, 22 Aug 2022 13:17:00 +0000 [thread overview]
Message-ID: <d6dc09aea26447ed99a4ad5cee62c048@axis.com> (raw)
In-Reply-To: <01dce5b603bc47fc195ba4ea738e7a333ac1992e.camel@linuxfoundation.org>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 22 augusti 2022 13:19
> To: Quentin Schulz <quentin.schulz@theobroma-systems.com>; Wes Lindauer
> <wesley.lindauer@gmail.com>; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH] bitbake.conf: Add resource vars to hash
> ignore list
>
> On Mon, 2022-08-22 at 11:28 +0200, Quentin Schulz wrote:
> > Hi Wes,
> >
> > On 8/22/22 06:59, Wes Lindauer wrote:
> > > It should not matter what xz/zstd parallelism and resource usage is set to
> > > when determining hash signatures. This allows sharing more sstate across
> > > host machines with different CPU configurations.
> > >
> >
> > It seems like it does matter in some ways, c.f.:
> > https://git.openembedded.org/openembedded-core/commit/?id=0296dc71c01d1b7953d74ef37d56429e2f4fcfab
> > and
> > https://git.openembedded.org/openembedded-core/commit/?id=e72c0b94554a9bc293844ec2bddb0c04ea19791d
>
> As Quentin mentions, the value does matter. In particular, those
> compiled with a single thread differ to those with multiple threads. As
> such the proposed patch can't be accepted.
>
> Cheers,
>
> Richard
Isn't the problem of varying XZ_THREAD/ZSTD_THREAD vs taskhashes
already taken care of by having:
XZ_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}"
XZ_THREADS[vardepvalue] = "1"
XZ_DEFAULTS ?= "--memlimit=${XZ_MEMLIMIT} --threads=${XZ_THREADS}"
XZ_DEFAULTS[vardepsexclude] += "XZ_MEMLIMIT XZ_THREADS"
ZSTD_THREADS ?= "${@oe.utils.cpu_count(at_least=2)}"
ZSTD_THREADS[vardepvalue] = "1"
in bitbake.conf.
//Peter
next prev parent reply other threads:[~2022-08-22 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 4:59 [OE-core][PATCH] bitbake.conf: Add resource vars to hash ignore list Wes Lindauer
2022-08-22 7:16 ` Ernst Sjöstrand
2022-08-22 9:28 ` Quentin Schulz
2022-08-22 11:18 ` Richard Purdie
2022-08-22 13:17 ` Peter Kjellerstedt [this message]
2022-08-30 19:27 ` Wes Lindauer
2022-08-30 19:41 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6dc09aea26447ed99a4ad5cee62c048@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=wesley.lindauer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox