public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Nate Karstens" <nate.karstens@garmin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][PATCH] openssl: Do not create /etc/ssl/certs
Date: Fri, 6 Nov 2020 06:55:49 +0000	[thread overview]
Message-ID: <d71df6ac554e452791305de8d2c1d8e2@garmin.com> (raw)
In-Reply-To: <3ef5e39f58625f8044ffd75e790df399979b2243.camel@linuxfoundation.org>

Richard,

Thanks for your help in looking into this. After looking at it further the OpenSSL code itself is creating the empty certs folder:

https://github.com/openssl/openssl/blob/f123043faa15965c34947670ff3d3a7005d6bdb4/Configurations/unix-Makefile.tmpl#L552

As such, we thought it would be unwise to modify the openssl recipe. Instead, we plan to change the conflicting recipe to use a post-installation script.

Cheers,

Nate

-----Original Message-----
From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
Sent: Tuesday, November 03, 2020 10:00
To: Karstens, Nate <Nate.Karstens@garmin.com>; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] openssl: Do not create /etc/ssl/certs

CAUTION - EXTERNAL EMAIL: Do not click any links or open any attachments unless you trust the sender and know the content is safe.


On Tue, 2020-11-03 at 07:44 -0600, Nate Karstens via lists.openembedded.org wrote:
> The openssl package previously created an empty folder for CA 
> certificates at /etc/ssl/certs. Other packages, like ca-certificates, 
> would then populate this folder.
>
> Certain systems need more flexibility with how this folder is created 
> and populated (e.g., a symlink is needed). To accommodate this, the 
> openssl recipe no longer creates the empty folder. Instead, the folder 
> will only be created by packages that populate it.
>
> Signed-off-by: Nate Karstens <nate.karstens@garmin.com>
> ---
>  meta/recipes-connectivity/openssl/openssl_1.1.1h.bb | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1h.bb 
> b/meta/recipes-connectivity/openssl/openssl_1.1.1h.bb
> index eb11fe3960..5723d19dbf 100644
> --- a/meta/recipes-connectivity/openssl/openssl_1.1.1h.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1h.bb
> @@ -134,14 +134,12 @@ do_install () {
>       # Create SSL structure for packages such as ca-certificates which
>       # contain hard-coded paths to /etc/ssl. Debian does the same.
>       install -d ${D}${sysconfdir}/ssl
> -     mv ${D}${libdir}/ssl-1.1/certs \
> -        ${D}${libdir}/ssl-1.1/private \
> +     mv ${D}${libdir}/ssl-1.1/private \
>          ${D}${libdir}/ssl-1.1/openssl.cnf \
>          ${D}${sysconfdir}/ssl/
>
>       # Although absolute symlinks would be OK for the target, they become
>       # invalid if native or nativesdk are relocated from sstate.
> -     ln -sf ${@oe.path.relative('${libdir}/ssl-1.1', '${sysconfdir}/ssl/certs')} ${D}${libdir}/ssl-1.1/certs
>       ln -sf ${@oe.path.relative('${libdir}/ssl-1.1', '${sysconfdir}/ssl/private')} ${D}${libdir}/ssl-1.1/private
>       ln -sf ${@oe.path.relative('${libdir}/ssl-1.1', 
> '${sysconfdir}/ssl/openssl.cnf')} ${D}${libdir}/ssl-1.1/openssl.cnf

When you asked about this in the previous email, I questioned whether we still needed the symlink. Did you check into that? I suspect we may need it as openssl itself may reference that path internally?

Cheers,

Richard


      reply	other threads:[~2020-11-06  6:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 13:44 openssl: Do not create /etc/ssl/certs nate.karstens
2020-11-03 13:44 ` [OE-core][PATCH] " Nate Karstens
2020-11-03 13:47   ` Nate Karstens
2020-11-03 16:00   ` Richard Purdie
2020-11-06  6:55     ` Nate Karstens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d71df6ac554e452791305de8d2c1d8e2@garmin.com \
    --to=nate.karstens@garmin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox