Re: [OE-core] [PATCH] gcc-target.inc: Fix gcc symlink handling for multilib support

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2024-11-13 at 04:51 -0800, Hemraj, Deepthi via lists.openembedded.org wrote:
> From: Deepthi Hemraj <Deepthi.Hemraj@windriver.com>
> 
> Enabling multilib support and adding both lib32-gcc-symlinks and gcc-symlinks
> to the image installation results in a conflict between
> gcc-symlinks-13.3.0-r0.corei7_64 and lib32-gcc-symlinks-13.3.0-r0.corei7_32.
> Following error occurs because of the conflict:
> "file /usr/bin/gcc conflicts between attempted installs of gcc-symlinks-13.3.0-r0.corei7_64 and lib32-gcc-symlinks-13.3.0-r0.corei7_32"
> 
> The conflict occurs because both packages try to install files in the same location,
> causing installation errors during the build process.
> 
> Updated the gcc target recipe to correctly handle symlinks for multilib support by using ${MLPREFIX}gcc
> instead of just gcc for the gcc binary symlink in ${PN}-symlinks.
> This ensures that the symlinks point to the appropriate multilib gcc binary for 32-bit and 64-bit configurations.
> 
> Signed-off-by: Deepthi Hemraj <Deepthi.Hemraj@windriver.com>
> ---
>  meta/recipes-devtools/gcc/gcc-target.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-target.inc b/meta/recipes-devtools/gcc/gcc-target.inc
> index 6b47c10413..ff59eb1b52 100644
> --- a/meta/recipes-devtools/gcc/gcc-target.inc
> +++ b/meta/recipes-devtools/gcc/gcc-target.inc
> @@ -71,7 +71,7 @@ FILES:${PN}-dev = "\
>  "
>  FILES:${PN}-symlinks = "\
>      ${bindir}/cc \
> -    ${bindir}/gcc \
> +    ${bindir}/${MLPREFIX}gcc \
>      ${bindir}/gccbug \
>  "
>  
> @@ -182,7 +182,7 @@ do_install () {
>  		ln -sf gfortran f95 || true
>  	fi
>  	ln -sf ${TARGET_PREFIX}g++ g++
> -	ln -sf ${TARGET_PREFIX}gcc gcc
> +	ln -sf ${TARGET_PREFIX}gcc ${MLPREFIX}gcc
>  	ln -sf ${TARGET_PREFIX}cpp cpp
>  	ln -sf ${TARGET_PREFIX}gcov gcov
>  	ln -sf ${TARGET_PREFIX}gcov-tool gcov-tool
> 

No, sorry, but definitely not.

You can install one of these or the other but both doesn't make any
sense, just don't do that.

I also don't understand how this fixes things since surely all the
other symlinks conflict too?

Cheers,

Richard