Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Michael Cooper <michaelcooper81@gmail.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Fix #13560 - Partition numbering is broken for MBR primary partition #4
Date: Thu, 03 Oct 2019 16:59:45 +0100	[thread overview]
Message-ID: <daf8cfafd4e22a8a2e91cbf8f53d134281aed2d5.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAEaKURdr0+G66Nm4-nOMVn_3yFUBJJAqxdgzovNuf4o9PyZL4A@mail.gmail.com>

On Thu, 2019-10-03 at 18:36 +0300, Michael Cooper wrote:
> Bug: When wks describes extra partitions that aren't in the partition
> table (e.g. boot loader) and exactly four primary MBR partitions, the
> last partition gets added to fstab as partition #5 instead of #4.
> 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=13560
> 
> Signed-off-by: Michael Cooper <michaelcooper81@gmail.com>
> ---
>  scripts/lib/wic/plugins/imager/direct.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, I've queued this.

For reference, your patch arrived line wrapped. It was simple enough I
could edit that out by hand (been doing this too long, clearly!).

I also tweaked the shortlog to match our guidelines and tweaked the bug
number reference to the standard [YOCTO #13560]. I just mention these
so you can sort next time, thanks for the patch!

Cheers,

Richard



  reply	other threads:[~2019-10-03 15:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 15:36 [PATCH] Fix #13560 - Partition numbering is broken for MBR primary partition #4 Michael Cooper
2019-10-03 15:59 ` Richard Purdie [this message]
2019-10-03 16:05   ` Michael Cooper
2019-10-03 16:02 ` ✗ patchtest: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daf8cfafd4e22a8a2e91cbf8f53d134281aed2d5.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=michaelcooper81@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox