Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Luca Bocassi <luca.boccassi@gmail.com>,
	openembedded-core@lists.openembedded.org
Cc: paul.eggleton@microsoft.com
Subject: Re: [OE-core] [PATCH v2 4/7] systemd: remove volatile-binds RDEPENDS for nativesdk
Date: Mon, 22 Nov 2021 11:56:19 +0000	[thread overview]
Message-ID: <db2638a45928ea0d875de1cc62c9fc4ea5dc9149.camel@linuxfoundation.org> (raw)
In-Reply-To: <20211119113429.502652-4-luca.boccassi@gmail.com>

On Fri, 2021-11-19 at 11:34 +0000, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> Not needed for SDK binaries
> 
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> v2: remove dependency instead of adding nativesdk to volatile-binds
> 
>  meta/recipes-core/systemd/systemd_249.5.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/systemd/systemd_249.5.bb b/meta/recipes-core/systemd/systemd_249.5.bb
> index 9993036aac..2928a85c93 100644
> --- a/meta/recipes-core/systemd/systemd_249.5.bb
> +++ b/meta/recipes-core/systemd/systemd_249.5.bb
> @@ -644,6 +644,7 @@ FILES:${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ $
>  RDEPENDS:${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) systemd-udev-rules util-linux-agetty util-linux-fsck"
>  RDEPENDS:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}"
>  RDEPENDS:${PN} += "volatile-binds"
> +RDEPENDS_${PN}_remove_class-nativesdk = "volatile-binds"
>  
>  RRECOMMENDS:${PN} += "systemd-extra-utils \
>                        udev-hwdb \

This patch raises a few questions like how this is being tested?

The override syntax changed so the avoid would never have worked with master.

Also, I have a strong preference for not using remove operators in OE-Core, you
can usually rearrange things so that it isn't necessary. The reason for that is
that it is very hard to override these operations. I know we do have some but
minimising them is good.

Cheers,

Richard



  reply	other threads:[~2021-11-22 11:56 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 12:31 [PATCH 0/8] systemd: allow building for nativesdk luca.boccassi
2021-11-17 12:31 ` [PATCH 1/8] systemd: skip chown when " luca.boccassi
2021-11-17 18:14   ` [OE-core] " Peter Kjellerstedt
2021-11-17 18:32     ` Luca Boccassi
2021-11-19 11:35       ` Luca Boccassi
2021-11-17 12:31 ` [PATCH 2/8] systemd: skip postinst in nativesdk builds luca.boccassi
2021-11-17 12:31 ` [PATCH 3/8] systemd: remove /var " luca.boccassi
2021-11-17 12:31 ` [PATCH 4/8] volatile-binds: " luca.boccassi
2021-11-17 12:31 ` [PATCH 5/8] volatile-binds: add nativesdk luca.boccassi
2021-11-17 17:40   ` [OE-core] " Richard Purdie
2021-11-17 17:42     ` Luca Boccassi
2021-11-19 11:36       ` Luca Boccassi
2021-11-17 12:31 ` [PATCH 6/8] kbd: " luca.boccassi
2021-11-17 17:43   ` [OE-core] " Richard Purdie
2021-11-17 17:58     ` Luca Boccassi
2021-11-17 12:32 ` [PATCH 7/8] os-release: " luca.boccassi
2021-11-17 12:32 ` [PATCH 8/8] systemd: " luca.boccassi
2021-11-17 12:53 ` [OE-core] [PATCH 0/8] systemd: allow building for nativesdk Alexander Kanavin
2021-11-17 14:59   ` Luca Boccassi
2021-11-17 15:07     ` Alexander Kanavin
2021-11-17 16:11       ` Luca Boccassi
2021-11-17 16:44         ` Alexander Kanavin
2021-11-17 17:41           ` Luca Boccassi
2021-11-17 17:49             ` Alexander Kanavin
2021-11-17 18:04               ` Luca Boccassi
2021-11-17 19:50                 ` Alexander Kanavin
2021-11-19  1:43 ` ChenQi
2021-11-19 11:26   ` Luca Boccassi
2021-11-22  3:32     ` ChenQi
2021-11-19 11:34 ` [PATCH v2 1/7] systemd: skip chown when " luca.boccassi
2021-11-19 11:34   ` [PATCH v2 2/7] systemd: skip postinst in nativesdk builds luca.boccassi
2021-11-19 11:34   ` [PATCH v2 3/7] systemd: remove /var " luca.boccassi
2021-11-19 11:34   ` [PATCH v2 4/7] systemd: remove volatile-binds RDEPENDS for nativesdk luca.boccassi
2021-11-22 11:56     ` Richard Purdie [this message]
2021-11-22 22:51       ` [OE-core] " Luca Boccassi
2021-11-19 11:34   ` [PATCH v2 5/7] kbd: add nativesdk luca.boccassi
2021-11-19 11:34   ` [PATCH v2 6/7] os-release: " luca.boccassi
2021-11-19 11:34   ` [PATCH v2 7/7] systemd: " luca.boccassi
2021-11-19 11:39     ` [OE-core] " Alexander Kanavin
2021-11-19 11:55       ` Luca Boccassi
2021-11-22 12:46   ` [OE-core] [PATCH v2 1/7] systemd: skip chown when building for nativesdk Richard Purdie
2021-11-22 13:57   ` Konrad Weihmann
2021-11-22 14:17     ` Alexander Kanavin
2021-11-22 22:47     ` Luca Boccassi
2021-11-24  8:09       ` Konrad Weihmann
2021-11-24 11:53         ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2638a45928ea0d875de1cc62c9fc4ea5dc9149.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=luca.boccassi@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox