From: akuster808 <akuster808@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [warrior][PATCH] bitbake.conf: add git-lfs to HOSTTOOLS_NONFATAL
Date: Thu, 15 Aug 2019 20:45:48 -0700 [thread overview]
Message-ID: <dc6b8ca1-411e-4381-e4da-7907052eca28@gmail.com> (raw)
In-Reply-To: <CAJ86T=Ux9UQs3eVJR5NOyZYJMMDtNRHr-Nppq0d5D5JFMryaMw@mail.gmail.com>
On 8/15/19 2:31 PM, Andre McCurdy wrote:
> On Thu, Aug 15, 2019 at 2:09 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> On Thu, 2019-08-15 at 09:23 +0200, Martin Jansa wrote:
>>> NAK
>>>
>>> Yes, the first part was merged in warrior and is correct.
>>>
>>> But this second part isn't good (you don't want git-lfs to sometimes
>>> work and sometimes fail) and that's why it was rejected for master
>>> and _shouldn't_ be merged to warrior. If you have recipes which need
>>> git-lfs, then add it to normal HOSTTOOLS in your builds to make sure
>>> it's always present when needed.
>> I don't like the patch but it did merge to master.
>>
>> Building a git-lfs-native is a nightmare due to all its dependencies (I
>> think its go based?) and there wasn't really any other way to sort it.
> Upstream provides generic binaries for at least x86, x86-64 and ARM64:
>
> https://github.com/git-lfs/git-lfs/releases
> https://github.com/git-lfs/git-lfs/releases/download/v2.8.0/git-lfs-linux-386-v2.8.0.tar.gz
> https://github.com/git-lfs/git-lfs/releases/download/v2.8.0/git-lfs-linux-amd64-v2.8.0.tar.gz
> https://github.com/git-lfs/git-lfs/releases/download/v2.8.0/git-lfs-linux-arm64-v2.8.0.tar.gz
>
> Would just downloading and installing the official upstream binaries be so bad?
making a big change like this seems to be a no-go for a stable branch.
- armin
>
>> Having recipe specific hosttools would be ideal but we don't have that.
>>
>> Cheers,
>>
>> Richard
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2019-08-16 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 6:53 [warrior][PATCH] bitbake.conf: add git-lfs to HOSTTOOLS_NONFATAL Naveen Saini
2019-08-15 7:03 ` Saini, Naveen Kumar
2019-08-15 7:23 ` Martin Jansa
2019-08-15 7:37 ` Saini, Naveen Kumar
2019-08-15 21:09 ` Richard Purdie
2019-08-15 21:31 ` Andre McCurdy
2019-08-16 3:45 ` akuster808 [this message]
2019-08-16 17:54 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc6b8ca1-411e-4381-e4da-7907052eca28@gmail.com \
--to=akuster808@gmail.com \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox