Re: [PATCH 1/4] oeqa/core/runner: write testresult to json files

[richard.purdie@linuxfoundation.org]

On Tue, 2018-10-23 at 06:39 +0000, Yeoh, Ee Peng wrote:
> I submitted the revised patches below. Sorry for the missing "version
> #" in the patch title. After this, I will add the "version #" into
> the patch title. 
> 
> Please let me know if any question or inputs. Thank you very much for
> your attention & sharing! 

Thanks for the changes. I was at a conference last week and then became
unwell. I wanted to have a further look and test the patches before
merging and I wanted a clearer head to do that.

Unfortunately I found another problem. On my build machine, it shows:

Traceback (most recent call last):
  File "/media/build1/poky/scripts/oe-selftest", line 70, in <module>
    ret = main()
  File "/media/build1/poky/scripts/oe-selftest", line 57, in main
    results = args.func(logger, args)
  File "/media/build1/poky/meta/lib/oeqa/selftest/context.py", line 289, in run
    rc = self._internal_run(logger, args)
  File "/media/build1/poky/meta/lib/oeqa/selftest/context.py", line 248, in _internal_run
    configuration = self._get_configuration(args)
  File "/media/build1/poky/meta/lib/oeqa/selftest/context.py", line 217, in _get_configuration
    metadata = metadata_from_bb()
  File "/media/build1/poky/meta/lib/oeqa/utils/metadata.py", line 42, in metadata_from_bb
    info_dict['layers'] = get_layers(data_dict['BBLAYERS'])
  File "/media/build1/poky/meta/lib/oeqa/utils/metadata.py", line 81, in get_layers
    layer_dict[layer_name] = git_rev_info(layer)
  File "/media/build1/poky/meta/lib/oeqa/utils/metadata.py", line 61, in git_rev_info
    from git import Repo, InvalidGitRepositoryError, NoSuchPathError
ModuleNotFoundError: No module named 'git'

That is obviously easily fixed by installing the git module but it does
raise some questions, in particular, why we have two code paths which
do the same thing (one in metadata_scm.bbclass and one in
lib/oeqa/utils/metadata.py).

It also means we've just added new module dependencies to oe-selftest
and the other test utilities which we don't test for anywhere or have
documented. Doing this last thing in M4 is bad.

So this is going to need a little more thought...

Cheers,

Richard