From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ross Burton <ross.burton@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] python: don't wipe RDEPENDS when parsing manifest
Date: Sun, 14 Oct 2018 09:49:33 +0100 [thread overview]
Message-ID: <deb7ad54c2b95773e123d2185639c6e5ae89b9ba.camel@linuxfoundation.org> (raw)
In-Reply-To: <20181012115502.14205-1-ross.burton@intel.com>
On Fri, 2018-10-12 at 12:55 +0100, Ross Burton wrote:
> We want to allow the main recipe to extend RDEPENDS directly, so
> don't wipe
> RDEPENDS when reading the manifest.
>
> This fixes the missing python-misc dependency from python-modules.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-devtools/python/python3_3.5.6.bb | 1 -
> meta/recipes-devtools/python/python_2.7.15.bb | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
> b/meta/recipes-devtools/python/python3_3.5.6.bb
> index e1796581342..489baa294fd 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -285,7 +285,6 @@ python(){
> for value in python_manifest[key]['cached']:
> d.appendVar('FILES_' + pypackage, ' ' + value)
>
> - d.setVar('RDEPENDS_' + pypackage, '')
> for value in python_manifest[key]['rdepends']:
> # Make it work with or without $PN
> if '${PN}' in value:
> diff --git a/meta/recipes-devtools/python/python_2.7.15.bb
> b/meta/recipes-devtools/python/python_2.7.15.bb
> index 472c1da4bf7..f30d3f4d25c 100644
> --- a/meta/recipes-devtools/python/python_2.7.15.bb
> +++ b/meta/recipes-devtools/python/python_2.7.15.bb
> @@ -240,7 +240,6 @@ python(){
> if value.endswith('.py'):
> d.appendVar('FILES_' + pypackage, ' ' + value +
> 'c')
>
> - d.setVar('RDEPENDS_' + pypackage, '')
> for value in python_manifest[key]['rdepends']:
> # Make it work with or without $PN
> if '${PN}' in value:
FWIW its actually this patch which is causing the build failures...
I did remember that rpm may detect python scripts and add a python
dependency which may be confusing things...
Cheers,
Richard
prev parent reply other threads:[~2018-10-14 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 11:55 [PATCH 1/3] python: don't wipe RDEPENDS when parsing manifest Ross Burton
2018-10-12 11:55 ` [PATCH 2/3] python: remove the PN package entirely Ross Burton
2018-10-13 7:10 ` Khem Raj
2018-10-13 10:23 ` Richard Purdie
2018-10-12 11:55 ` [PATCH 3/3] python: clean up ptest Ross Burton
2018-10-14 8:49 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb7ad54c2b95773e123d2185639c6e5ae89b9ba.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox