From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
Jose Quaresma <quaresma.jose@gmail.com>
Subject: Re: [OE-core] [PATCH] libical: Pass TOOLCHAIN_OPTIONS via CFLAGS
Date: Thu, 03 Mar 2022 23:15:40 +0000 [thread overview]
Message-ID: <df36f0c75a79adeda5d6f57297efaccb4fd54bda.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1soDJbtUY1qrkGXjUw86XzNSF+4VD3fv=Kr8MuqXR7tjGA@mail.gmail.com>
On Thu, 2022-03-03 at 15:05 -0800, Khem Raj wrote:
> On Thu, Mar 3, 2022 at 2:53 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Mon, 2022-02-28 at 20:13 -0800, Khem Raj wrote:
> > > This ensures that right sysroot is used during build, otherwise we see
> > > warnings in build about using wrong sysroot and it fails explicitly with
> > > clang
> > >
> > > x86_64-yoe-linux-ld: warning: library search path "/usr/lib/gcc/x86_6
> > > 4-pc-linux-gnu/11.2.0/../../../../lib64" is unsafe for cross-compilation
> > >
> > > x86_64-yoe-linux-ld: cannot find /usr/lib/clang/14.0.0/lib/linux/libc
> > > lang_rt.builtins-x86_64.a: No such file or directory
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > > meta/recipes-support/libical/libical_3.0.14.bb | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/meta/recipes-support/libical/libical_3.0.14.bb b/meta/recipes-support/libical/libical_3.0.14.bb
> > > index 717eb11e125..879ad8ed595 100644
> > > --- a/meta/recipes-support/libical/libical_3.0.14.bb
> > > +++ b/meta/recipes-support/libical/libical_3.0.14.bb
> > > @@ -18,6 +18,8 @@ UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases"
> > >
> > > inherit cmake pkgconfig gobject-introspection vala
> > >
> > > +CFLAGS += "${TOOLCHAIN_OPTIONS}"
> > > +
> > > DEPENDS += "libical-native"
> > >
> > > PACKAGECONFIG ??= "icu glib"
> >
> >
> > I gave this (and the cmake patch) a go and whilst it mostly worked, it doesn't
> > work on arm (qemuarm or beaglebone):
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/4855
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/3774
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/4829
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/3715
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/4825
> >
> > Any ideas?
>
> I think we need to check why CC is being passed here from env
> explicitly when invoking g-ir-scanner-wrapper, which is bare compiler
> without TOOLCHAIN_OPTIONS and this cmd seems to not
> respect CFLAGS
>
> > [95/112] cd /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical
> && /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/cmake
> -E env "CC='/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-gcc'"
> /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot/usr/bin/g-ir-scanner-wrapper
> --c-include=libical/ical.h --pkg-export libical
> --identifier-prefix=ical
> -I/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/libical-3.0.14/src/libical
> /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ical.h
> --namespace=ICal --nsversion=3.0 --no-libtool --library=ical
> --include=GObject-2.0
> -L/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/lib
> --output /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ICal-3.0.gir
> --accept-unprefixed
>
> I will take a look later today.
Thanks, I'll be asleep shortly I hope! :)
>
> btw. is this the only failure left ?
>
For that patch in core, yes, I think so.
Cheers,
Richard
>
next prev parent reply other threads:[~2022-03-03 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 4:13 [PATCH] libical: Pass TOOLCHAIN_OPTIONS via CFLAGS Khem Raj
2022-03-03 22:53 ` [OE-core] " Richard Purdie
2022-03-03 23:05 ` Khem Raj
2022-03-03 23:15 ` Richard Purdie [this message]
2022-03-04 8:38 ` Jose Quaresma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df36f0c75a79adeda5d6f57297efaccb4fd54bda.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=quaresma.jose@gmail.com \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox