Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jacob Kroon <jacob.kroon@gmail.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel-devsrc: Don't package kernel meta-data
Date: Thu, 4 Aug 2016 09:48:13 +0200	[thread overview]
Message-ID: <dfd0136b-fb2a-51a2-b66a-3d5e63c5d2e1@gmail.com> (raw)
In-Reply-To: <CADkTA4MYqHCQ0AiR72dxhVAVw0=K7Ui-F3ip3jS9x6gUE_5VqA@mail.gmail.com>

On 08/04/2016 03:41 AM, Bruce Ashfield wrote:
> On Wed, Aug 3, 2016 at 5:33 AM, Jacob Kroon <jacob.kroon@gmail.com
> <mailto:jacob.kroon@gmail.com>> wrote:
[...]
>     Ignore this patch, I'm suspecting that .kernel-meta/ directory
>     shouldn't exist in ${STAGING_KERNEL_DIR} to begin with ?
>
>
> It doesn't hurt anything by being there, but you can either intercept it
> at the
> time we stage the common kernel parts, or when you package devsrc .. either
> will work.

Since commit 3b49416fc7a7ee9bfe722f2e6089aa18df41dc58, linux-yocto.inc
does:

do_install_append(){
	if [ -n "${KMETA}" ]; then
		rm -rf ${STAGING_KERNEL_DIR}/${KMETA}
	fi
}

But I think this accidentally got broken by a later commit
3b2b4eef0fd06099342fcc2dfa35ecf37840c090, which changed the directory
name by conditionally prepending a ".":

kmeta = d.getVar( "KMETA", True ) or "meta"
if not os.path.exists(kmeta):
     kmeta = "." + kmeta

So it seems to me that the right thing to do here would be to fix and
move the do_install_append() to kernel-yocto.bbclass. Bruce, what do
you think ?

Regards Jacob


  reply	other threads:[~2016-08-04  7:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 16:56 [PATCH] kernel-devsrc: Don't package kernel meta-data Jacob Kroon
2016-08-03  9:33 ` Jacob Kroon
2016-08-04  1:41   ` Bruce Ashfield
2016-08-04  7:48     ` Jacob Kroon [this message]
2016-08-05  1:19       ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfd0136b-fb2a-51a2-b66a-3d5e63c5d2e1@gmail.com \
    --to=jacob.kroon@gmail.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox