From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bastet.se.axis.com (bastet.se.axis.com [195.60.68.11]) by mail.openembedded.org (Postfix) with ESMTP id 93D086067C for ; Wed, 10 Oct 2018 08:21:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 18C24184B3; Wed, 10 Oct 2018 10:21:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id BNJEL22R5qMB; Wed, 10 Oct 2018 10:21:04 +0200 (CEST) Received: from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16]) by bastet.se.axis.com (Postfix) with ESMTPS id BB9931807C; Wed, 10 Oct 2018 10:21:04 +0200 (CEST) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5D681A084; Wed, 10 Oct 2018 10:21:04 +0200 (CEST) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AAE51A081; Wed, 10 Oct 2018 10:21:04 +0200 (CEST) Received: from thoth.se.axis.com (unknown [10.0.2.173]) by boulder02.se.axis.com (Postfix) with ESMTP; Wed, 10 Oct 2018 10:21:04 +0200 (CEST) Received: from XBOX01.axis.com (xbox01.axis.com [10.0.5.15]) by thoth.se.axis.com (Postfix) with ESMTP id 8E8642E7F; Wed, 10 Oct 2018 10:21:04 +0200 (CEST) Received: from XBOX02.axis.com (10.0.5.16) by XBOX01.axis.com (10.0.5.15) with Microsoft SMTP Server (TLS) id 15.0.1365.1; Wed, 10 Oct 2018 10:21:04 +0200 Received: from XBOX02.axis.com ([fe80::d00f:cb52:1b56:20d]) by XBOX02.axis.com ([fe80::d00f:cb52:1b56:20d%21]) with mapi id 15.00.1365.000; Wed, 10 Oct 2018 10:21:04 +0200 From: Peter Kjellerstedt To: Richard Purdie Thread-Topic: [OE-core] [PATCH 1/3] acl: Make it compatible with externalsrc Thread-Index: AQHUVDlL2fqHNLeM0kiHgltnZAF9BaUAhT8AgAAxiWCACxUtoIAMbqhw Date: Wed, 10 Oct 2018 08:21:04 +0000 Message-ID: References: <20180924190313.32027-1-pkj@axis.com> <7083c560991d491f0e8b8b70eee611c1187b58d0.camel@linuxfoundation.org> <56e1792adf9e4c97ad12230ec9df8fde@XBOX02.axis.com> In-Reply-To: <56e1792adf9e4c97ad12230ec9df8fde@XBOX02.axis.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.0.5.60] MIME-Version: 1.0 X-TM-AS-GCONF: 00 Cc: "openembedded-core@lists.openembedded.org" Subject: Re: [PATCH 1/3] acl: Make it compatible with externalsrc X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 08:21:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Except for the questions asked and answered below, is there=20 anything else preventing these three patches from being merged? //Peter > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org core-bounces@lists.openembedded.org> On Behalf Of Peter Kjellerstedt > Sent: den 2 oktober 2018 12:26 > To: Richard Purdie ; openembedded- > core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH 1/3] acl: Make it compatible with > externalsrc >=20 > *ping* >=20 > //Peter >=20 > > -----Original Message----- > > From: openembedded-core-bounces@lists.openembedded.org > core-bounces@lists.openembedded.org> On Behalf Of Peter Kjellerstedt > > Sent: den 25 september 2018 11:17 > > To: Richard Purdie ; openembedded-c= ore@lists.openembedded.org > > Subject: Re: [OE-core] [PATCH 1/3] acl: Make it compatible with externa= lsrc > > > > > -----Original Message----- > > > From: openembedded-core-bounces@lists.openembedded.org > > core-bounces@lists.openembedded.org> On Behalf Of Richard Purdie > > > Sent: den 25 september 2018 10:13 > > > To: Peter Kjellerstedt ; openembedded- > > > core@lists.openembedded.org > > > Subject: Re: [OE-core] [PATCH 1/3] acl: Make it compatible with > > > externalsrc > > > > > > On Mon, 2018-09-24 at 21:03 +0200, Peter Kjellerstedt wrote: > > > > Make the subdir fetch path for configure.ac relative. This avoids t= he > > > > following error after having done `devtool modify acl`: > > > > > > > > ERROR: acl-2.2.52-r0 do_unpack: Unpack failure for URL: > > > > 'file://configure.ac;subdir=3D.../builds/qemux86-64/workspace/sourc= es/acl'. > > > > subdir argument isn't a subdirectory of unpack root > > > > .../builds/qemux86-64/tmp/work/core2-64-poky-linux/acl/2.2.52-r0 > > > > > > > > Signed-off-by: Peter Kjellerstedt > > > > --- > > > > meta/recipes-support/attr/acl_2.2.52.bb | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/meta/recipes-support/attr/acl_2.2.52.bb b/meta/recipes= -support/attr/acl_2.2.52.bb > > > > index 8f3dc45cf7..8b89de9b42 100644 > > > > --- a/meta/recipes-support/attr/acl_2.2.52.bb > > > > +++ b/meta/recipes-support/attr/acl_2.2.52.bb > > > > @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM =3D "file://doc/COPYING;md5=3Dc7= 81d70ed2b4d48995b790403217a249 \ > > > > DEPENDS =3D "attr" > > > > > > > > SRC_URI =3D "${SAVANNAH_GNU_MIRROR}/acl/${BP}.src.tar.gz \ > > > > - file://configure.ac;subdir=3D${S} \ > > > > + file://configure.ac;subdir=3D${BP} \ > > > > file://run-ptest \ > > > > file://acl-fix-the-order-of-expected-output-of-getfacl.= patch \ > > > > file://test-fix-insufficient-quoting-of.patch \ > > > > > > This isn't making sense to me. Doesn't externalsrc set ${S} to the > > > external source location? > > > > Yes, it does, but it does not change ${WORKDIR}. So when it tries > > to unpack to the absolute path ${S}, which is outside ${WORKDIR} > > when externalsrc is in use, then the above error occurs. Using a > > relative path avoids the problem. > > > > > Also, doesn't it remove the do_unpack task? > > > > No, it keeps the task but removes everything except file:// URLs > > and URLs with type=3Dkmeta from the SRC_URI. This is also why I had > > to check for externalsrc in the do_unpack task of lsof. > > > > > Cheers, > > > > > > Richard > > > > //Peter