Re: [OE-core] [meta-gplv2][PATCH 1/1] util-linux: remove GPLv3 and pylibmount

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Thu, 2020-08-27 at 13:28 +0200, Adrian Freihofer wrote:
> python bindings are GPLv3+.
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>  recipes-core/util-linux/util-linux_%.bbappend | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 recipes-core/util-linux/util-linux_%.bbappend
> 
> diff --git a/recipes-core/util-linux/util-linux_%.bbappend b/recipes-
> core/util-linux/util-linux_%.bbappend
> new file mode 100644
> index 0000000..abd31c5
> --- /dev/null
> +++ b/recipes-core/util-linux/util-linux_%.bbappend
> @@ -0,0 +1,10 @@
> +# pylibmount is GPLv3 -> remove
> +LICENSE = "GPLv2+ & LGPLv2.1+ & BSD-3-Clause & BSD-4-Clause"
> +
> +PACKAGECONFIG_remove = "pylibmount"
> +
> +do_install_append() {
> +    rm -f ${D}${PYTHON_SITEPACKAGES_DIR}/libmount/pylibmount.so
> +    rm -f ${D}${PYTHON_SITEPACKAGES_DIR}/libmount/__init__.*
> +    rm -rf ${D}${PYTHON_SITEPACKAGES_DIR}/libmount/__pycache__
> +}

I think this change unconditionally changes the recipe and means
including the layer adds the change. That will break YP Compatibility
and means meta-gplv2 isn't YP Compatible. I think (but haven't
confirmed) this will break the yocto-check-layer tests on the
autobuilder.

Also, resetting LICENSE is a really bad idea as if someone adds a new
license, this will hide/override it. A remove there may be better too.

Cheers,

Richard