From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Steve Sakoman <steve@sakoman.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core][dunfell 3/9] devshell.bbclass: Allow devshell & pydevshell to use the network
Date: Tue, 3 May 2022 07:52:21 +0000 [thread overview]
Message-ID: <e1dfa49e3a2b44b8af449ff171dfba9e@axis.com> (raw)
In-Reply-To: <214a2fe628801af3fde5b540c31f1c515f6c855f.1651531749.git.steve@sakoman.com>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Steve Sakoman
> Sent: den 3 maj 2022 01:03
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core][dunfell 3/9] devshell.bbclass: Allow devshell &
> pydevshell to use the network
>
> From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
>
> Otherwise it will fail if using OE_TERMINAL = "xterm" with the not so
> helpful error:
>
> xterm: Xt error: Can't open display: localhost:0.0
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit ba53fc3bcecfe32401471dc1008c7ead96504150)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
> meta/classes/devshell.bbclass | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/devshell.bbclass b/meta/classes/devshell.bbclass
> index 76dd0b42ee..ad9f267848 100644
> --- a/meta/classes/devshell.bbclass
> +++ b/meta/classes/devshell.bbclass
> @@ -21,6 +21,7 @@ addtask devshell after do_patch
> do_prepare_recipe_sysroot
> DEVSHELL_STARTDIR ?= "${S}"
> do_devshell[dirs] = "${DEVSHELL_STARTDIR}"
> do_devshell[nostamp] = "1"
> +do_devshell[network] = "1"
>
> # devshell and fakeroot/pseudo need careful handling since only the final
> # command should run under fakeroot emulation, any X connection should
> @@ -154,3 +155,4 @@ python do_devpyshell() {
> addtask devpyshell after do_patch
>
> do_devpyshell[nostamp] = "1"
> +do_devpyshell[network] = "1"
> --
> 2.25.1
This shouldn't be needed for Dunfell, should it? I would assume the support
for blocking network operations per task hasn't been backported.
//Peter
next prev parent reply other threads:[~2022-05-03 7:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 23:02 [OE-core][dunfell 0/9] Patch review Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 1/9] python3: ignore CVE-2015-20107 Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 2/9] busybox: Use base_bindir instead of hardcoding /bin path Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 3/9] devshell.bbclass: Allow devshell & pydevshell to use the network Steve Sakoman
2022-05-03 7:52 ` Peter Kjellerstedt [this message]
2022-05-03 13:55 ` Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 4/9] cases/buildepoxy.py: fix typo Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 5/9] install/devshell: Introduce git intercept script due to fakeroot issues Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 6/9] base: Drop git intercept Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 7/9] bitbake.conf: mark all directories as safe for git to read Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 8/9] neard: Switch SRC_URI to git repo Steve Sakoman
2022-05-02 23:02 ` [OE-core][dunfell 9/9] uninative: Upgrade to 3.6 with gcc 12 support Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1dfa49e3a2b44b8af449ff171dfba9e@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox