Re: [OE-core] [v4] [RFC] Merge meta-rust to oe-core - Aug 19 update

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Sun, 2021-08-22 at 08:45 -0400, Randy MacLeod wrote:
> On 2021-08-22 7:19 a.m., Richard Purdie wrote:
> > On Sat, 2021-08-21 at 23:12 -0400, Randy MacLeod wrote:
> > > On 2021-08-20 10:48 p.m., Randy MacLeod wrote:
> > > With a patch from Richard, and the http_proxy check removed,
> > > $ git diff | grep "^[+-]"
> > >   --- a/meta/lib/oeqa/selftest/cases/sstatetests.py
> > >   +++ b/meta/lib/oeqa/selftest/cases/sstatetests.py
> > >   -http_proxy = "http://example.com/"
> > >   +http_proxy = ""
> > >   
> > > we have fixed the oe-selftest that was failing.
> > >   Any volunteers to stub out the http[s]_proxy code in cargo ?
> > > I've written up a commit log that could use some review and pushed an update
> > > to:
> > >     
> > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=rmacleod/rust-redo-aug-17-2021-a
> > > 
> > 
> > 
> > I'm not sure you need to change cargo, I think if you remove the bit in the
> > bbclass that injects http_proxy, the tests are ok. That will perhaps break
> > anyone using proxies but for now, I think that is a reasonable step of getting
> > this moved forward?
> 
> That's what I hoped for as well but not what my testing showed.
> 
> I removed (commented out actually) the http_proxy injection here:
>  
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=rmacleod/rust-redo-aug-17-2021-a&id=a4808f787caf8d0b44cf3946cf204164f24f91d4
> 
> but the test still fails unless I mangle the test:
> 
>     meta/lib/oeqa/selftest/cases/sstatetests.py
> 
> 
>     -http_proxy = "http://example.com/"
> 
> 
>     +http_proxy = ""

Right, my point is that doesn't remove it. You need to delete it, not comment it
out.

The issue is that bitbake does variable expansion on the scripts before running
them.

It can't tell that this is a comment, just that the script differs after
variable expansion.

Cheers,

Richard