public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Tim Orling <ticotimo@gmail.com>,
	openembedded-core@lists.openembedded.org
Cc: Tim Orling <timothy.t.orling@intel.com>
Subject: Re: [OE-core] [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0
Date: Thu, 26 Aug 2021 17:12:39 +0100	[thread overview]
Message-ID: <e4091533694cd7b4a93407bf131eea0a28191c4d.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210825202805.714379-1-timothy.t.orling@intel.com>

On Wed, 2021-08-25 at 20:28 +0000, Tim Orling wrote:
> * All ptests pass on qemux86-64
> 
> pluggy 1.0.0 (2021-08-25)
> 
> Deprecations and Removals
> 
>     #116: Remove deprecated implprefix support. Decorate hook
> 	  implementations using an instance of HookimplMarker instead.
> The deprecation was announced in release 0.7.0.
>     #120: Remove the deprecated proc argument to call_historic. Use
> 	  result_callback instead, which has the same behavior. The
> deprecation was announced in release 0.7.0.
>     #265: Remove the _Result.result property. Use _Result.get_result()
> 	  instead. Note that unlike result, get_result() raises the
> exception if the hook raised. The deprecation was announced in release
> 0.6.0.
>     #267: Remove official support for Python 3.4.
>     #272: Dropped support for Python 2. Continue to use pluggy 0.13.x
> 	  for Python 2 support.
>     #308: Remove official support for Python 3.5.
>     #313: The internal pluggy.callers, pluggy.manager and pluggy.hooks
> 	  are now explicitly marked private by a _ prefix (e.g.
> pluggy._callers). Only API exported by the top-level pluggy module is
> considered public.
>     #59: Remove legacy __multicall__ recursive hook calling system. The
> 	 deprecation was announced in release 0.5.0.
> 
> Features
> 
>     #282: When registering a hookimpl which is declared as
> 	  hookwrapper=True but whose function is not a generator
> function, a PluggyValidationError exception is now raised.
> 
>     Previously this problem would cause an error only later, when
> calling the hook.
> 
>     In the unlikely case that you have a hookwrapper that returns a
> generator instead of yielding directly, for example:
> 
>     def my_hook_real_implementation(arg):
>         print("before")
>         yield
>         print("after")
> 
>     @hookimpl(hookwrapper=True)
>     def my_hook(arg):
>         return my_hook_implementation(arg)
> 
>     change it to use yield from instead:
> 
>     @hookimpl(hookwrapper=True)
>     def my_hook(arg):
>         yield from my_hook_implementation(arg)
> 
>     #309: Add official support for Python 3.9.
> 
> Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
> ---
>  .../{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb}      | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>  rename meta/recipes-devtools/python/{python3-pluggy_0.13.1.bb => python3-pluggy_1.0.0.bb} (80%)

I haven't proof but I suspect this has caused python3-jinja2's ptests to
regress:

https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/2433/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/2152/steps/12/logs/stdio

I didn't spot this before it merged unfortunately.

Cheers,

Richard


  reply	other threads:[~2021-08-26 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 20:28 [PATCH] python3-pluggy: upgrade 0.13.1 -> 1.0.0 Tim Orling
2021-08-26 16:12 ` Richard Purdie [this message]
2021-08-26 16:53   ` [OE-core] " Tim Orling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4091533694cd7b4a93407bf131eea0a28191c4d.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ticotimo@gmail.com \
    --cc=timothy.t.orling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox