public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ejo@pengutronix.de, openembedded-core@lists.openembedded.org
Cc: yocto@pengutronix.de, Alexander Kanavin <alex.kanavin@gmail.com>
Subject: Re: [OE-core] [PATCH v6 3/7] barebox: set default BAREBOX_CONFIG for qemu machines
Date: Fri, 11 Oct 2024 12:08:51 +0100	[thread overview]
Message-ID: <e5673b2af275dd6bddde40223581c3cdbb310968.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240912091857.2631678-4-ejo@pengutronix.de>

On Thu, 2024-09-12 at 11:18 +0200, Enrico Jörns via lists.openembedded.org wrote:
> From: Enrico Jorns <ejo@pengutronix.de>
> 
> These are set in the barebox recipe rather in the corresponding machines
> (where they would belong otherwise) to keep the impact of barebox to
> oe-core minimal for now.
> 
> "multi_v7_defconfig" is used for qemuarm since this is the default
> barebox armv7 config that just enables all supported platforms.
> 
> "multi_v8_defconfig" is used for qemuarm64 sine this is the default
> barebox armv8 config that just enables all supported platforms.
> 
> "efi_defconfig" is used for qemux86-64 which is the primary platform
> where barebox will not be the first stage bootloader but an EFI payload.
> 
> Since these changes make barebox a provider for virtual/bootloader,
> explicitly default to u-boot in the corresponding MACHINE configs to not
> unnecessarily surprise users.
> 
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> ---
>  meta/conf/machine/qemuarm.conf    | 1 +
>  meta/conf/machine/qemuarm64.conf  | 1 +
>  meta/conf/machine/qemux86-64.conf | 1 +
>  3 files changed, 3 insertions(+)

This patch needs the commit message updating as it no longer matches
the changes below!

Things did pass in automated testing so I think we're close with this.

Cheers,

Richard

> diff --git a/meta/conf/machine/qemuarm.conf b/meta/conf/machine/qemuarm.conf
> index 943ce7c16a..af76a53b8e 100644
> --- a/meta/conf/machine/qemuarm.conf
> +++ b/meta/conf/machine/qemuarm.conf
> @@ -7,6 +7,7 @@ require conf/machine/include/qemu.inc
>  
>  KERNEL_IMAGETYPE = "zImage"
>  
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot"
>  UBOOT_MACHINE ?= "qemu_arm_defconfig"
>  
>  SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0"
> diff --git a/meta/conf/machine/qemuarm64.conf b/meta/conf/machine/qemuarm64.conf
> index a096d964db..d310445a34 100644
> --- a/meta/conf/machine/qemuarm64.conf
> +++ b/meta/conf/machine/qemuarm64.conf
> @@ -7,6 +7,7 @@ require conf/machine/include/qemu.inc
>  
>  KERNEL_IMAGETYPE = "Image"
>  
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot"
>  UBOOT_MACHINE ?= "qemu_arm64_defconfig"
>  
>  SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0"
> diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
> index 14873a3b4f..4a9c6d364b 100644
> --- a/meta/conf/machine/qemux86-64.conf
> +++ b/meta/conf/machine/qemux86-64.conf
> @@ -13,6 +13,7 @@ DEFAULTTUNE ?= "core2-64"
>  require conf/machine/include/x86/tune-x86-64-v3.inc
>  require conf/machine/include/x86/qemuboot-x86.inc
>  
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot"
>  UBOOT_MACHINE ?= "qemu-x86_64_defconfig"
>  
>  KERNEL_IMAGETYPE = "bzImage"
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#204432): https://lists.openembedded.org/g/openembedded-core/message/204432
> Mute This Topic: https://lists.openembedded.org/mt/108410146/1686473
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [richard.purdie@linuxfoundation.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



  parent reply	other threads:[~2024-10-11 11:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12  9:18 [PATCH v6 0/7] Add barebox bootloader support (and testing) Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 1/7] barebox: add initial support Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 2/7] barebox-tools: add initial barebox tools support Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 3/7] barebox: set default BAREBOX_CONFIG for qemu machines Enrico Jörns
2024-10-11 11:08   ` [OE-core] " Richard Purdie
2024-10-11 11:08   ` Richard Purdie [this message]
2024-10-11 11:22     ` Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 4/7] oeqa/utils/qemurunner: support ignoring vt100 escape sequences Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 5/7] oeqa: support passing custom boot patterns to runqemu Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 6/7] oeqa/selftest/cases: add basic u-boot test Enrico Jörns
2024-09-12  9:18 ` [PATCH v6 7/7] oeqa/selftest/cases: add basic barebox tests Enrico Jörns
2024-09-18 10:11 ` [OE-core] [PATCH v6 0/7] Add barebox bootloader support (and testing) Richard Purdie
2024-09-18 10:39   ` Enrico Jörns
2024-09-18 11:21     ` Richard Purdie
2024-09-18 11:45       ` Enrico Jörns
2024-09-18 21:37         ` Richard Purdie
2024-09-19  9:47           ` Enrico Jörns
2024-09-19 10:01             ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5673b2af275dd6bddde40223581c3cdbb310968.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=ejo@pengutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yocto@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox