Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Randy MacLeod <randy.macleod@windriver.com>
To: Yash.Shinde@windriver.com, openembedded-core@lists.openembedded.org
Cc: Sundeep.Kokkonda@windriver.com
Subject: Re: [PATCH v2 2/3] rust: Upgrade 1.86.0 -> 1.87.0
Date: Wed, 25 Jun 2025 14:34:25 -0400	[thread overview]
Message-ID: <e5cea1de-4053-49c5-b409-31e79b15c9cd@windriver.com> (raw)
In-Reply-To: <20250625102014.1199159-2-Yash.Shinde@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2188 bytes --]

On 2025-06-25 6:20 a.m., Yash.Shinde@windriver.com wrote:
> From: Yash Shinde<Yash.Shinde@windriver.com>
>
> Rust stable version updated to 1.87.0.
> https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/
>
> * Update LLVM data-layout for arm64.
>    LLVM requires matching data layouts and
>    the aarch64 llvm data-layout was updated to to allow using
>    32-bit signed/unsigned pointers when building 64-bit targets
>    using 270, 271 and 272 address spaces.
>
>    https://github.com/rust-lang/rust/commit/e9853961452b56997cc127b51308879b9cd09482
>    https://github.com/llvm/llvm-project/commit/c9f27275c1330a325661bdf14fb3bc444a5e3648
>
> * Rebase existing patches with v1.87.0.
>
> * Two tests from the `ui` and `codegen` modules now fail only on riscv64.
>    Enable them on arm32/64 and x86-32/64 targets, while restricting
>    them on riscv64 via `only-<target_arch>` tags.
>
>    Test Results Summary:
>
>    +-----------+--------+---------+
>    | Machine   | Passed | Ignored |
>    +-----------+--------+---------+
>    | arm-32    | 28,320 | 901     |
>    | arm-64    | 28,400 | 849     |
>    | x86-32    | 28,285 | 885     |
>    | x86-64    | 28,518 | 676     |
>    | riscv-64  | 27,845 | 868     |
>    +-----------+--------+---------+
>
> * Backport triagebot.patch to skip tidy linkcheck when triagebot.toml
>    is not present. Distribution tarballs won't include triagebot.toml,
>    which causes tidy checks to fail.
>    This backport ensures tidy checks can still run successfully
>    even when the file is missing.
>
>    https://github.com/rust-lang/rust/pull/142666/commits
>
> * During rust installation, some binaries were installed from
>    'stage2-tools' built path to '${D}${bindir}'. However, from
>    v1.87 the stage2-tools are no longer built by default.
>    Update logic to install from `stage1-tools` instead.
>
> Signed-off-by: Yash Shinde<Yash.Shinde@windriver.com>
Much better commit log, thanks.
> ---
> Include test result summary and enhance commit message details.
The line above was likely a note for yourself but
it's harmless noise since it's below the --- separator.

LGTM.

../Randy

<snip>

-- 
# Randy MacLeod
# Wind River Linux

[-- Attachment #2: Type: text/html, Size: 3383 bytes --]

  reply	other threads:[~2025-06-25 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 10:20 [PATCH v2 1/3] rust: Drop obsolete rust-lld and extended tools dependencies Yash.Shinde
2025-06-25 10:20 ` [PATCH v2 2/3] rust: Upgrade 1.86.0 -> 1.87.0 Yash.Shinde
2025-06-25 18:34   ` Randy MacLeod [this message]
2025-06-25 10:20 ` [PATCH v2 3/3] cargo-c-native: Update 0.10.5 -> 0.10.13 Yash.Shinde
2025-06-25 10:32   ` Patchtest results for " patchtest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5cea1de-4053-49c5-b409-31e79b15c9cd@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=Yash.Shinde@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox