Re: [OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

Tim Orling
2024-01-16T18:57:16Z

[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]

On Tue, Jan 16, 2024 at 9:21 AM Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> How about simple depending on specific module packages? I don’t think
> OpenSSL truly needs all modules.
>

Agreed. I don’t see a compelling reason to add the perl-modules-force-all
complication. This will add confusion in my opinion.

Iterate the tests and add the required perl-module-* sub-packages one by
one (or by inspection if the test cases)

In almost all cases, RDEPENDS on perl-modules is a short cut and should be
avoided in favor of being explicit.

> Alex
>
> On Tue 16. Jan 2024 at 17.56, Lyu, William via lists.openembedded.org
> <william.lyu=windriver.com@lists.openembedded.org> wrote:
>
>> From: William Lyu <William.Lyu@windriver.com>
>>
>> Change the openssl-ptest RDEPENDS from perl-modules to
>> perl-modules-force-all which RDEPENDS on the same set of packages
>> perl-module-* recommended by perl-modules. So, when openssl-ptest is
>> added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on these
>> perl-module-* packages still get added.
>>
>> Signed-off-by: William Lyu <William.Lyu@windriver.com>
>> ---
>> meta/recipes-connectivity/openssl/openssl_3.2.0.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> index d041d2d214..7076bd3a7b 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> @@ -247,7 +247,7 @@ CONFFILES:openssl-conf =
>> "${sysconfdir}/ssl/openssl.cnf"
>>
>> RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
>> RDEPENDS:${PN}-misc = "perl"
>> -RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
>> +RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules-force-all bash
>> sed"
>>
>> RDEPENDS:${PN}-bin += "openssl-conf"
>>
>> --
>> 2.43.0
>>
>>
>>
>>
>>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#193868):
> https://lists.openembedded.org/g/openembedded-core/message/193868
> Mute This Topic: https://lists.openembedded.org/mt/103766390/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 4645 bytes --]