Re: [OE-core] [RFC PATCH 1/2] classes/buildhistory: record SRC_URI

Mikko Rapeli
2020-10-29T09:18:51Z

On Wed, Oct 28, 2020 at 02:21:22PM +0000, Richard Purdie wrote:
> On Mon, 2020-10-26 at 06:43 +0000, Mikko Rapeli wrote:
> > On Sun, Oct 18, 2020 at 09:03:56PM -0700, Paul Eggleton wrote:
> > > From: Paul Eggleton <paul.eggleton@microsoft.com>
> > >
> > > It can be useful to record SRC_URI into buildhistory for the
> > > purposes of
> > > tracking exactly which sources got built (we already have SRCREV)
> > > as
> > > well as getting an indication when changes to the SRC_URI relate to
> > > changes in the output.
> > >
> > > Signed-off-by: Paul Eggleton <paul.eggleton@microsoft.com>
> >
> > I have similar patch in our poky trees. Also have patches
> > to export LICENSE and CVE_PRODUCT to buildhistory. These are used
> > by some post-build QA check scripts.
> >
> > Acked-by: Mikko Rapeli <mikko.rapeli@bmw.de>
>
> I'm actually fairly against some of these kinds of changes.
> Buildhistory is meant to be there to highlight changes in the output
> over time. Using it to create manifests and for license checking
> purposes is not what it was designed for.
>
> I just feel if the original author of the class thinks its a good idea
> I need to give up :/.

Surely changes in LICENSE and SRC_URI over time are important for an overview
of changes?

At least to me they are pretty much essential. I'm using buildhistory diffs to
see what changes in major yocto updates for example once builds are passing.

Cheers,

-Mikko

>
> Cheers,
>
> Richard