Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>,
	Openembedded-core@lists.openembedded.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [OE-core] [PATCH 2/2] oeqa/utils/postactions: transfer whole archive over ssh instead of doing individual copies
Date: Mon, 08 Jul 2024 22:37:42 +0100	[thread overview]
Message-ID: <e9961bfdfdbee4085d010b0ad818a9411e1f130a.camel@linuxfoundation.org> (raw)
In-Reply-To: <e5e4514e-5db0-4d0b-a20a-11e2d786a543@bootlin.com>

On Mon, 2024-07-08 at 23:10 +0200, Alexis Lothoré wrote:
> Hello Richard,
> 
> On 7/7/24 10:10, Richard Purdie wrote:
> > On Fri, 2024-07-05 at 16:46 +0200, Alexis Lothoré via lists.openembedded.org wrote:
> > > From: Alexis Lothoré <alexis.lothore@bootlin.com>
> > > +    try:
> > > +        cmd = f"tar zcf - {" ".join(artifacts_list)}"
> > 
> > Thanks for the patch. The syntax above causes failures:
> > 
> > https://valkyrie.yoctoproject.org/#/builders/95/builds/59/steps/14/logs/stdio
> > 
> > I've put a fix on master-next which I can squash in but it does make me
> > wonder how it was tested.
> 
> Sorry about that. This error made me doubt about my testing setup, so I ran new
> tests, and I confirm that this line is being executed and returns a correct tar
> command on my machine, which confused me even more because it indeed looks broken.
> 
> My best guess about those differences is a mismatch on python versions between
> the autobuilder and my machine. I am running python 3.12, and it appears that it
> has brought many improvements to python f-strings, especially "quote reuse",
> which makes python not raise an exception anymore when the expression inside an
> f-string reuses the same kind of quotes as for the parent f-string (see [1]). I
> ran a quick test with Python 3.11 instead of 3.12, and I now I see the exception.

That explains things. I'm very surprised any version of python accepts
that formatting to be honest!

> I guess it would be better for me to keep working with the same python version
> as in the autobuilder. I see mentions of python 3.6 in README-WALKTHROUGHS.md
> from the autobuilder2 repository, but I am not sure how up-to-date it is. Could
> you please confirm whether this is the correct version or not?

The docs are out of date and the definitive version is the one checked in bitbake:

https://git.openembedded.org/bitbake/tree/lib/bb/__init__.py#n15

"Sorry, python 3.8.0 or later is required for this version of bitbake"

so 3.8+ is our current requirement.

Cheers,

Richard


  reply	other threads:[~2024-07-08 21:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 14:46 [PATCH 0/2] oeqa/utils/postactions: fix disk storage consumption Alexis Lothoré
2024-07-05 14:46 ` [PATCH 1/2] oeqa/ssh: allow to retrieve raw, unformatted ouput Alexis Lothoré
2024-07-05 14:46 ` [PATCH 2/2] oeqa/utils/postactions: transfer whole archive over ssh instead of doing individual copies Alexis Lothoré
2024-07-05 15:06   ` Patchtest results for " patchtest
2024-07-07  8:10   ` [OE-core] " Richard Purdie
2024-07-08 21:10     ` Alexis Lothoré
2024-07-08 21:37       ` Richard Purdie [this message]
2024-07-09  8:06         ` Alexis Lothoré

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9961bfdfdbee4085d010b0ad818a9411e1f130a.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox