From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by mail.openembedded.org (Postfix) with ESMTP id AF47477A41 for ; Wed, 26 Apr 2017 14:29:38 +0000 (UTC) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3wCjC65Pphz1rHs0; Wed, 26 Apr 2017 16:29:38 +0200 (CEST) Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3wCjC64fNCz3hhWY; Wed, 26 Apr 2017 16:29:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id N4O3L_QeR3EP; Wed, 26 Apr 2017 16:29:37 +0200 (CEST) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Wed, 26 Apr 2017 16:29:37 +0200 (CEST) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 38B964540436; Wed, 26 Apr 2017 16:29:37 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([127.0.0.1]) by localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pbk1T2R5sWb6; Wed, 26 Apr 2017 16:29:34 +0200 (CEST) Received: from [192.168.178.132] (papero.fritz.box [192.168.178.132]) by babic.homelinux.org (Postfix) with ESMTP id 220F8454028E; Wed, 26 Apr 2017 16:29:34 +0200 (CEST) To: Bruce Ashfield , Stefano Babic References: <1493212797-10326-1-git-send-email-sbabic@denx.de> From: Stefano Babic Message-ID: Date: Wed, 26 Apr 2017 16:29:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 14:29:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 26/04/2017 15:56, Bruce Ashfield wrote: > > > On Wed, Apr 26, 2017 at 9:19 AM, Stefano Babic > wrote: > > In case the defconfig was created with "make savedefconfig", it is not > enough to copy it to defconfig as it is done now. In fact, running make > ${KBUILD_DEFCONFIG}, as usually when building the kernel outside poky, > does much more and the resulting .config file is different as the > starting one. > The file generated by "make savedefconfig" contains in most cases a > subset of all options that are required for the kernel, and other > options are inserted automatically when make is called. > > Signed-off-by: Stefano Babic > > --- > meta/classes/kernel-yocto.bbclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/kernel-yocto.bbclass > b/meta/classes/kernel-yocto.bbclass > index 0330270..27ff8b7 100644 > --- a/meta/classes/kernel-yocto.bbclass > +++ b/meta/classes/kernel-yocto.bbclass > @@ -109,7 +109,8 @@ do_kernel_metadata() { > bbwarn "defconfig detected > in WORKDIR. ${KBUILD_DEFCONFIG} skipped" > fi > else > - cp -f > ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG} ${WORKDIR}/defconfig > + oe_runmake -C ${S} O=${B} > ${KBUILD_DEFCONFIG} > > > > This would need to be a different mode in the configuration task, not here. > This routine only gathers inputs, and doesn't process them. > Understood. > I have an open bug for this, and a WIP patch that will go out early in the > 2.4 release cycle. > Got it, thanks for info ! Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================