From: Steve Sakoman <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][kirkstone 21/31] glib-2.0: fix rare GFileInfo test case failure
Date: Thu, 3 Nov 2022 17:00:56 -1000 [thread overview]
Message-ID: <eb208256778a941aa38b8dba1cb0897e36908cdb.1667530733.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1667530733.git.steve@sakoman.com>
From: Ross Burton <ross.burton@arm.com>
If a access or creation timestamp has 0 microseconds, then the test
fails as it doesn't expect this to be a valid value. Expand a previous
fix for modification times to cover these timestamps too.
[ YOCTO #14373 ]
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 15715e6ad81c97cd50e288f3745615eb19be90d1)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
...-info-don-t-assume-million-in-one-ev.patch | 51 +++++++++++++++++++
meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb | 1 +
2 files changed, 52 insertions(+)
create mode 100644 meta/recipes-core/glib-2.0/glib-2.0/0001-gio-tests-g-file-info-don-t-assume-million-in-one-ev.patch
diff --git a/meta/recipes-core/glib-2.0/glib-2.0/0001-gio-tests-g-file-info-don-t-assume-million-in-one-ev.patch b/meta/recipes-core/glib-2.0/glib-2.0/0001-gio-tests-g-file-info-don-t-assume-million-in-one-ev.patch
new file mode 100644
index 0000000000..c33fa88a76
--- /dev/null
+++ b/meta/recipes-core/glib-2.0/glib-2.0/0001-gio-tests-g-file-info-don-t-assume-million-in-one-ev.patch
@@ -0,0 +1,51 @@
+Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2990]
+Signed-off-by: Ross Burton <ross.burton@arm.com>
+
+From 14838522a706ebdcc3cdab661d4c368099fe3a4e Mon Sep 17 00:00:00 2001
+From: Ross Burton <ross.burton@arm.com>
+Date: Tue, 6 Jul 2021 19:26:03 +0100
+Subject: [PATCH] gio/tests/g-file-info: don't assume million-in-one events
+ don't happen
+
+The access and creation time tests create a file, gets the time in
+seconds, then gets the time in microseconds and assumes that the
+difference between the two has to be above 0.
+
+As rare as this may be, it can happen:
+
+$ stat g-file-info-test-50A450 -c %y
+2021-07-06 18:24:56.000000767 +0100
+
+Change the test to simply assert that the difference not negative to
+handle this case.
+
+This is the same fix as 289f8b, but that was just modification time.
+---
+ gio/tests/g-file-info.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/gio/tests/g-file-info.c b/gio/tests/g-file-info.c
+index 59411c3a8..a213e4b92 100644
+--- a/gio/tests/g-file-info.c
++++ b/gio/tests/g-file-info.c
+@@ -239,7 +239,7 @@ test_g_file_info_access_time (void)
+ g_assert_nonnull (dt_usecs);
+
+ ts = g_date_time_difference (dt_usecs, dt);
+- g_assert_cmpint (ts, >, 0);
++ g_assert_cmpint (ts, >=, 0);
+ g_assert_cmpint (ts, <, G_USEC_PER_SEC);
+
+ /* Try round-tripping the access time. */
+@@ -316,7 +316,7 @@ test_g_file_info_creation_time (void)
+ g_assert_nonnull (dt_usecs);
+
+ ts = g_date_time_difference (dt_usecs, dt);
+- g_assert_cmpint (ts, >, 0);
++ g_assert_cmpint (ts, >=, 0);
+ g_assert_cmpint (ts, <, G_USEC_PER_SEC);
+
+ /* Try round-tripping the creation time. */
+--
+2.34.1
+
diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
index dd1ea508d2..b5ab6502a3 100644
--- a/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
+++ b/meta/recipes-core/glib-2.0/glib-2.0_2.72.3.bb
@@ -16,6 +16,7 @@ SRC_URI = "${GNOME_MIRROR}/glib/${SHRT_VER}/glib-${PV}.tar.xz \
file://0001-Do-not-write-bindir-into-pkg-config-files.patch \
file://0001-meson-Run-atomics-test-on-clang-as-well.patch \
file://0001-gio-tests-resources.c-comment-out-a-build-host-only-.patch \
+ file://0001-gio-tests-g-file-info-don-t-assume-million-in-one-ev.patch \
"
SRC_URI:append:class-native = " file://relocate-modules.patch"
--
2.25.1
next prev parent reply other threads:[~2022-11-04 3:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 3:00 [OE-core][kirkstone 00/31] Patch review Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 01/31] openssl: export necessary env vars in SDK Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 02/31] openssl: Fix SSL_CERT_FILE to match ca-certs location Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 03/31] openssl: CVE-2022-3358 Using a Custom Cipher with NID_undef may lead to NULL encryption Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 04/31] openssl: Upgrade 3.0.5 -> 3.0.7 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 05/31] lighttpd: fix CVE-2022-41556 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 06/31] tiff: fix CVE-2022-2953 Steve Sakoman
2022-11-07 9:10 ` Shubham Kulkarni
2022-11-07 14:19 ` Steve Sakoman
2022-11-09 10:27 ` Shubham Kulkarni
2022-11-04 3:00 ` [OE-core][kirkstone 07/31] expat: backport the fix for CVE-2022-43680 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 08/31] wayland: fix CVE-2021-3782 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 09/31] cve-update-db-native: add timeout to urlopen() calls Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 10/31] vim: Upgrade 9.0.0598 -> 9.0.0614 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 11/31] vim: upgrade 9.0.0614 -> 9.0.0820 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 12/31] ifupdown: upgrade 0.8.37 -> 0.8.39 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 13/31] scripts/oe-check-sstate: cleanup Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 14/31] scripts/oe-check-sstate: force build to run for all targets, specifically populate_sysroot Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 15/31] psplash: add psplash-default in rdepends Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 16/31] opkg-utils: use a git clone, not a dynamic snapshot Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 17/31] insane.bbclass: Allow hashlib version that only accepts on parameter Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 18/31] oe/packagemanager/rpm: don't leak file objects Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 19/31] u-boot: Remove duplicate inherit of cml1 Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 20/31] bluez5: add dbus to RDEPENDS Steve Sakoman
2022-11-04 3:00 ` Steve Sakoman [this message]
2022-11-04 3:00 ` [OE-core][kirkstone 22/31] gnutls: Unified package names to lower-case Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 23/31] meson: make wrapper options sub-command specific Steve Sakoman
2022-11-04 3:00 ` [OE-core][kirkstone 24/31] buildtools-tarball: export certificates to python and curl Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 25/31] qemu-native: Add PACKAGECONFIG option for jack Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 26/31] runqemu: Do not perturb script environment Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 27/31] runqemu: Fix gl-es argument from causing other arguments to be ignored Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 28/31] overlayfs: Allow not used mount points Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 29/31] cmake-native: Fix host tool contamination (Bug: 14951) Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 30/31] ltp: backport clock_gettime04 fix from upstream Steve Sakoman
2022-11-04 3:01 ` [OE-core][kirkstone 31/31] perf: Depend on native setuptools3 Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb208256778a941aa38b8dba1cb0897e36908cdb.1667530733.git.steve@sakoman.com \
--to=steve@sakoman.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox