Re: [OE-core] [PATCH 22/24] scripts/lib/wic/partition.py: do not set FAT size

["Khem Raj" <raj.khem@gmail.com>]

On 2/28/21 7:37 AM, Alexander Kanavin wrote:
> Modern dosfstools automatically determines the appropriate size
> and will error out if something that doesn't make sense is
> supplied on the command line.

leaving it to tool seem to make it non-deterministic, is there any 
disadvantage of using a manual fallback default

> 
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>   scripts/lib/wic/partition.py | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py
> index 85f9847047..76d144d12d 100644
> --- a/scripts/lib/wic/partition.py
> +++ b/scripts/lib/wic/partition.py
> @@ -339,8 +339,6 @@ class Partition():
>               label_str = "-n %s" % self.label
>   
>           size_str = ""
> -        if self.fstype == 'msdos':
> -            size_str = "-F 16" # FAT 16
>   
>           extraopts = self.mkfs_extraopts or '-S 512'
>   
> @@ -422,8 +420,6 @@ class Partition():
>               label_str = "-n %s" % self.label
>   
>           size_str = ""
> -        if self.fstype == 'msdos':
> -            size_str = "-F 16" # FAT 16
>   
>           extraopts = self.mkfs_extraopts or '-S 512'
>   
> 
> 
> 
> 
>