Re: [OE-core] [meta-oe][PATCH v3] sudo: split into smaller tools package

Sinan Kaya
2020-12-15T19:54:08Z

On 12/15/2020 2:44 PM, Bruce Ashfield wrote:
>> -FILES_${PN} += "${nonarch_libdir}/tmpfiles.d"
> I don't see this maintained in the split of changes below, why was it dropped ?
>

I'll fix that. I thought ${libdir} would cover it but apparently it does
not.

>> FILES_${PN}-dev += "${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*.la \
>> ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la"
>> +
>> +PACKAGES += "${PN}-cvtsudoers"
>> +PACKAGES += "${PN}-sudoreplay"
>> +PACKAGES += "${PN}-visudo"
>> +PACKAGES += "${PN}-sudo"
>> +PACKAGES += "${PN}-lib"
>> +
>> +RDEPENDS_${PN}-cvtsudoers = "${PN}-lib"
>> +RDEPENDS_${PN}-sudo = "${PN}-lib"
>> +RDEPENDS_${PN}-sudoreplay = "${PN}-lib"
>> +RDEPENDS_${PN}-visudo = "${PN}-lib"
>> +
>> +PROVIDES += "${PACKAGES}"
>> +RRECOMMENDS_${PN} += "${PACKAGES}"

> This isn't a direct replacement of the existing packaging. If we are
> going to get a series of patches that keep splitting on binaries, they
> shouldn't be like this.
>> For an image or configuration that turns off rrecommends (which is the
> policy for a distro that I have), this is not backwards compatible and
> we are going to get all sorts of runtime issues .. and then be forced
> to update packages lists with this explosion of new splits.

Interesting, I didn't know that RRECOMMENDS can be turned off.
I was hoping to do a non-invasive change for existing users.

>
> If we do splits like this, something stronger than rrcommends is
> needed, or they simply belong in a layer besides core.

Would RDEPENDS work?

Sinan