From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mail.openembedded.org (Postfix) with ESMTP id 51F8A74CC9 for ; Thu, 5 Apr 2018 09:23:15 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 02:23:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,410,1517904000"; d="scan'208";a="40878239" Received: from kanavin-desktop.fi.intel.com (HELO [10.237.68.161]) ([10.237.68.161]) by orsmga003.jf.intel.com with ESMTP; 05 Apr 2018 02:23:15 -0700 From: Alexander Kanavin To: Chen Qi , openembedded-core@lists.openembedded.org References: <2e27990d1f27a0de84fc204caf77c28e5015173e.1522837858.git.Qi.Chen@windriver.com> <11a298c3-7fed-c73e-be12-0ed099fca145@linux.intel.com> Message-ID: Date: Thu, 5 Apr 2018 12:16:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <11a298c3-7fed-c73e-be12-0ed099fca145@linux.intel.com> Subject: Re: [PATCH 1/1] rpm: remove dbus dependency for rpm-native X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 09:23:16 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 04/04/2018 02:32 PM, Alexander Kanavin wrote: >> +# dbus dependency is deliberately omitted for rpm-native to prevent >> it from attempting to >> +# inhibit shutdown via session dbus, even when some layer enables >> plugins support for rpm-native. >> +DEPENDS_remove_class-native = "dbus" >> + >>   inherit autotools gettext pkgconfig python3native >>   export PYTHON_ABI >> @@ -63,7 +67,7 @@ EXTRA_OECONF_append_libc-musl = " --disable-nls" >>   # >>   # --localstatedir prevents rpm from writing its database to native >> sysroot when building images >>   # >> -# Also disable plugins, so that rpm doesn't attempt to inhibit >> shutdown via session dbus >> +# Disable plugins for rpm-native. >>   EXTRA_OECONF_append_class-native = " --sysconfdir=/etc >> --localstatedir=/var --disable-plugins" > > > This should definitely be a PACKAGECONFIG option. Actually, two > different options: "plugins" (pulls in dbus) and "plugins-native" (does > not pull in dbus). Then both can be enabled for target and native, > respectively. Actually, no, neither of these ideas is correct. If dbus is removed from explicit dependencies, that does not guarantee that it will not get pulled into rpm sysroot by something else that rpm depends on. You need to either patch configure.ac in rpm source code to add an explicit enable/disable-dbus switch, or to enable plugins in all cases, and remove the unneeded plugin at do_install tim when building rpm-native. Alex