Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: alexis.lothore@bootlin.com, Openembedded-core@lists.openembedded.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [OE-Core][PATCH] scripts/resulttool: group all regressions in regression report
Date: Sat, 04 Nov 2023 11:13:32 +0000	[thread overview]
Message-ID: <eee499bd9c5445eeae353677ed3d9611a046845a.camel@linuxfoundation.org> (raw)
In-Reply-To: <20231103205018.19693-1-alexis.lothore@bootlin.com>

On Fri, 2023-11-03 at 13:50 -0700, Alexis Lothoré via
lists.openembedded.org wrote:
> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> Commit c304fcbe0588b1078373558c2ddf36064bcdf214 introduced a grouping when
> listing regressions. This grouping has been added only for ptests. It has
> been observed that any other kind of tests could benefit from it. For
> example, current regression reports can show the following:
> 
> 1 regression(s) for oescripts.OEGitproxyTests.test_oegitproxy_proxy_dash
>     oescripts.OEGitproxyTests.test_oegitproxy_proxy_dash: PASSED -> SKIPPED
> 1 regression(s) for oescripts.OEPybootchartguyTests.test_pybootchartguy_help
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_help: PASSED -> SKIPPED
> 1 regression(s) for oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_pdf_output
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_pdf_output: PASSED -> SKIPPED
> 1 regression(s) for oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_png_output
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_png_output: PASSED -> SKIPPED
> 1 regression(s) for oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_svg_output
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_svg_output: PASSED -> SKIPPED
> [...]
> 
> This output is not so useful in its current state and should be grouped per
> test type too.
> Enable grouping for all kind of tests, to make it llok like the following
> in reports:
> 5 regression(s) for oescripts
>     oescripts.OEGitproxyTests.test_oegitproxy_proxy_dash: PASSED -> SKIPPED
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_help: PASSED -> SKIPPED
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_pdf_output: PASSED -> SKIPPED
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_png_output: PASSED -> SKIPPED
>     oescripts.OEPybootchartguyTests.test_pybootchartguy_to_generate_build_svg_output: PASSED -> SKIPPED
> 

Do you have a different example? This one is tricky as I happen to know
that test depends on the host distro and the things available there.
There are some distros it will pass on, there are some where it is
always skipped. There was a recipetool test added recently which will
do something similar depending upon host python version.

The challenge is we run the test on different host distros so it is
hard to see it as a regression. I don't know what we can do to make
this "clear" to the report reader...

The patch is probably ok as it doesn't make the output worse but it has
probably already obfuscated things a bit.

Cheers,

Richard


  reply	other threads:[~2023-11-04 11:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03 20:50 [OE-Core][PATCH] scripts/resulttool: group all regressions in regression report Alexis Lothoré
2023-11-04 11:13 ` Richard Purdie [this message]
2023-11-06 21:20   ` Alexis Lothoré

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eee499bd9c5445eeae353677ed3d9611a046845a.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexis.lothore@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox