From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: pgowda cve <pgowda.cve@gmail.com>
Cc: openembedded-core@lists.openembedded.org,
Randy.MacLeod@windriver.com, vinay.m.engg@gmail.com
Subject: Re: [OE-core] [PATCH v10] Rust Oe-Selftest implementation
Date: Wed, 07 Sep 2022 16:07:45 +0100 [thread overview]
Message-ID: <ef6bdb20f27290c82f60f1f3ea04a2b4f066bd2a.camel@linuxfoundation.org> (raw)
In-Reply-To: <CALY4987n9cs0EWx-+yTd37mPcxJkNAK95B_uB278vGy_RvdqRg@mail.gmail.com>
On Wed, 2022-09-07 at 20:34 +0530, pgowda cve wrote:
> Hi Richard,
>
> Thanks for pointing this out and your help in improving the patch.
> I am using an Ubuntu-18.04 machine and am not able to see the error.
>
> > > Something is mangling spaces in your patch. There shouldn't be tabs here.
> Fixed.
>
> > > I think this can be merged with the RustSelfTestBase class as I don't
> Merged.
>
> > > If we want to change grammar, it should be in a separate patch.
> Removed it.
Thanks for tweaking these.
>
> > > addtask do_test_compile after do_configure do_rust_gen_targets
> > > put that alongside the task definition.
> Added along with addtask definition.
I clearly wasn't clear enough!
It should be next to where the task is defined in rust_1.63.0.bb, i.e.
alongside the do_test_compile task definition itself.
Cheers,
Richard
prev parent reply other threads:[~2022-09-07 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220904063331.82988-1-naveen.gowda@windriver.com>
2022-09-04 13:34 ` [PATCH v10] Rust Oe-Selftest implementation Richard Purdie
2022-09-05 14:55 ` [OE-core] " pgowda cve
2022-09-05 21:56 ` Richard Purdie
2022-09-07 14:05 ` Richard Purdie
2022-09-07 15:04 ` pgowda cve
2022-09-07 15:07 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef6bdb20f27290c82f60f1f3ea04a2b4f066bd2a.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Randy.MacLeod@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pgowda.cve@gmail.com \
--cc=vinay.m.engg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox