Re: [RFC PATCH 1/1] image-live.bbclass: order do_bootimg after do_rootfs

["Ferry Toth" <fntoth@gmail.com>]

Hi

Op 26-05-2021 om 20:32 schreef Guillaume Champagne:
> do_bootimg expects IMGDEPLOYDIR to exist, since it stores its artifacts
> there. Therefore, do_bootimg should run after do_rootfs because
> IMGDEPLOYDIR is created before do_rootfs runs since IMGDEPLOYDIR is
> contained in do_rootfs' [cleandirs] varflag.
>
> When do_bootimg depends on ${PN}:do_image_${LIVE_ROOTFS_TYPE},
> do_bootimg is correctly ordered after do_rootfs because
> do_image_${FSTYPE} tasks are added after do_image and do_image itself is
> added after do_rootfs.
>
> However, when do_bootimg doesn't depend on
> ${PN}:do_image_${LIVE_ROOTFS_TYPE}
> (introduced by: 96f47c39f1d17f073243913d524bde84add41d8f), do_bootimg
> can run before do_rootfs, thus before IMGDEPLOYDIR is created. To
> avoid this situation, do_bootimg is now explicitly ordered after
> do_rootfs.
>
> Signed-off-by: Guillaume Champagne <champagne.guillaume.c@gmail.com>
> ---
> meta/classes/image-live.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image-live.bbclass 
> b/meta/classes/image-live.bbclass
> index 8b08305cdb..fd876ed8e1 100644
> --- a/meta/classes/image-live.bbclass
> +++ b/meta/classes/image-live.bbclass
> @@ -261,4 +261,4 @@ python do_bootimg() {
> do_bootimg[subimages] = "hddimg iso"
> do_bootimg[imgsuffix] = "."
> -addtask bootimg before do_image_complete
> +addtask bootimg before do_image_complete after do_rootfs

I can not answer your question if this is the right way to go. But I'll 
try this patch next weekend and return here with the results.

Thanks!