Re: [OE-core] [PATCH] perl: Fix perl-module-* being ignored via COMPLEMENTARY_GLOB

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2024-01-23 at 10:35 +0100, Alexander Kanavin wrote:
> On Tue, 23 Jan 2024 at 00:51, Lyu, William via lists.openembedded.org
> <william.lyu=windriver.com@lists.openembedded.org> wrote:
> > > Do you have some examples of these packages which don't exist?
> > > 
> > > I'd like to understand why they don't exist and perhaps not have them
> > > listed in PACKAGES in the first place. Creating a load of empty/useless
> > > packages with ALLOW_EMPTY seems a bit pointless/sad.
> > 
> > The following is a list of empty packages perl-modules RDEPENDS on.
> > 
> > tmp/work/core2-64-poky-linux/perl/5.38.2/packages-split$ find -maxdepth 1 -empty -name 'perl-module-*'
> > ./perl-module-config
> > ./perl-module-warnings-register
> > ./perl-module-vars
> > ./perl-module-strict
> > ./perl-module-config-git
> > ./perl-module-warnings
> 
> All of these are special-cased by the recipe to be packaged into the
> main perl package (and it sets RPROVIDES for them too). As the module
> package split is done with do_split_packages(), there are two options:
> - adjust file regexes in calls to that function to exclude the above items
> - (easier, and fine with me) set ALLOW_EMPTY only specifically for the
> above list, and not all module packages.

I have a third option. After calling do_split_packages(), iterate
through RPROVIDES_${PN} and for earch perl-module- item, remove any
matching entry from PACKAGES. Setting PACKAGES is basically what
do_split_packages does so we can tweak it afterwards.

If we remove the items from PACKAGES, the RDEPENDS for perl-modules
will then be correct and we don't have bogus empty packages lying
around.

Cheers,

Richard