From: Mark Hatle <mark.hatle@windriver.com>
To: Hongxu Jia <hongxu.jia@windriver.com>,
<openembedded-core@lists.openembedded.org>,
<ross.burton@intel.com>
Subject: Re: [PATCH 1/1] package_manager.py: fix bitbake package-index failed
Date: Tue, 13 Sep 2016 09:49:38 -0500 [thread overview]
Message-ID: <f035c95d-e904-b9bd-4d2b-f744a6976db5@windriver.com> (raw)
In-Reply-To: <8c9eea181c3ed9e9bac6d5d6480351795860e2e6.1473756300.git.hongxu.jia@windriver.com>
FYI this is fixing Yocto Project defect 10258.
--Mark
On 9/13/16 3:48 AM, Hongxu Jia wrote:
> Previously the following commit in oe-core move RPM metadata
> from DEPLOY_DIR to WORKDIR.
> -----------
> commit a92c196449c516fe51786d429078bbb1213bb029
> Author: Stephano Cetola <stephano.cetola@linux.intel.com>
> Date: Wed Aug 10 13:03:16 2016 -0700
>
> Allow for simultaneous do_rootfs tasks with rpm
>
> Give each rootfs its own RPM channel to use. This puts the RPM metadata
> in a private subdirectory of $WORKDIR, rather than living in DEPLOY_DIR
> where other tasks may race with it.
> -----------
>
> In the modification of 'class RpmIndexer, it should not
> directly set arch_dir with WORKDIR. It caused 'bitbake
> package-index' could not work correctly.
>
> Assign WORKDIR as input parameter at RpmIndexer initial time
> could fix the issue.
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
> meta/lib/oe/package_manager.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
> index 2802254..30e1de9 100644
> --- a/meta/lib/oe/package_manager.py
> +++ b/meta/lib/oe/package_manager.py
> @@ -176,7 +176,7 @@ class RpmIndexer(Indexer):
> dbpath = os.path.join(self.d.getVar('WORKDIR', True), 'rpmdb', arch)
> if os.path.exists(dbpath):
> bb.utils.remove(dbpath, True)
> - arch_dir = os.path.join(self.d.getVar('WORKDIR', True), 'rpms', arch)
> + arch_dir = os.path.join(self.deploy_dir, arch)
> if not os.path.isdir(arch_dir):
> continue
>
> @@ -686,7 +686,8 @@ class RpmPM(PackageManager):
> if not os.path.exists(self.d.expand('${T}/saved')):
> bb.utils.mkdirhier(self.d.expand('${T}/saved'))
>
> - self.indexer = RpmIndexer(self.d, self.deploy_dir)
> + packageindex_dir = os.path.join(self.d.getVar('WORKDIR', True), 'rpms')
> + self.indexer = RpmIndexer(self.d, packageindex_dir)
> self.pkgs_list = RpmPkgsList(self.d, self.target_rootfs, arch_var, os_var)
>
> self.ml_prefix_list, self.ml_os_list = self.indexer.get_ml_prefix_and_os_list(arch_var, os_var)
>
prev parent reply other threads:[~2016-09-13 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:48 [PATCH 0/1] package_manager.py: fix bitbake package-index failed Hongxu Jia
2016-09-13 8:48 ` [PATCH 1/1] " Hongxu Jia
2016-09-13 14:49 ` Mark Hatle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f035c95d-e904-b9bd-4d2b-f744a6976db5@windriver.com \
--to=mark.hatle@windriver.com \
--cc=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox