Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Tom King <ka6sox@gmail.com>
Cc: Joe Slater <joe.slater@windriver.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] cleansstate
Date: Mon, 24 Aug 2020 22:08:22 +0100	[thread overview]
Message-ID: <f058d2bf3e7d880aed5682d958e8afc0b90f752d.camel@linuxfoundation.org> (raw)
In-Reply-To: <fb0fa58a-cf84-9a5f-5b5e-489bd154b257@prevas.dk>

On Mon, 2020-08-24 at 23:05 +0200, Rasmus Villemoes wrote:
> On 22/08/2020 09.27, Richard Purdie via lists.openembedded.org wrote:
> > On Fri, 2020-08-21 at 17:32 -0700, Tom King wrote:
> > > What would be a use case for cleanstate?
> > 
> > I never really wanted to add it at all. There is/was some case for
> > wanting to remove sstate objects and ensure something really does
> > rebuild from source. When sstate was new and had more issues,
> > people
> > really wanted it and I was pushed into having it exist.
> > 
> > I understand why people want it although it should never really
> > need to
> > be used.
> 
> Well, except when you discover that your sstate is effectively
> corrupted/polluted by objects that happen to have the same hashes as
> those computed from current recipes, but the build artifacts
> would/should be different. Such as when using a file://foo/* glob
> pattern in SRC_URI.

Where such issues are reported, we do try and fix them. I hadn't quite
connected that the globbing issue was actually breaking sstate hashes,
that is more worrying :(

> 
> Richard, I'm still hoping you'd respond in the
> https://lists.openembedded.org/g/openembedded-core/topic/75235594
> thread. As I see it, half-way supporting glob patterns in file://
> URIs is a giant footgun.

My leaning is to remove them. You can just do file://foo and I think
that actually works?

The globs are horrible for a lot of different reasons.

Cheers,

Richard


  reply	other threads:[~2020-08-24 21:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 23:28 cleansstate Joe Slater
2020-08-21 15:14 ` [OE-core] cleansstate Richard Purdie
2020-08-22  0:32   ` tom king
2020-08-22  7:27     ` Richard Purdie
2020-08-24 18:13       ` Joe Slater
2020-08-24 21:05       ` Rasmus Villemoes
2020-08-24 21:08         ` Richard Purdie [this message]
2020-08-25  6:18           ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f058d2bf3e7d880aed5682d958e8afc0b90f752d.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=joe.slater@windriver.com \
    --cc=ka6sox@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rasmus.villemoes@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox