Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Kai <kai.kang@windriver.com>, Christopher Larson <kergoth@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs
Date: Fri, 26 Feb 2021 11:02:20 +0000	[thread overview]
Message-ID: <f073090d3108e89bfb8ef59fdccd42b472df782b.camel@linuxfoundation.org> (raw)
In-Reply-To: <0a2eff5a-9121-e31f-abee-47c096799e85@windriver.com>

On Fri, 2021-02-26 at 09:57 +0800, Kai wrote:
> On 2/25/21 11:29 PM, Christopher Larson wrote:
>  
> > Are we sure we want to completely override it rather than adding 
> > to it? I'd be rather irritated if this blows away my prompt 
> > without my asking for it. I think either it should append or 
> > have a variable controlling whether this is enabled when building 
> > the SDK.
> The original requirement is that the PS1 after source sdk environment 
> file is as same as the original one.
> It can not tell whether in a sdk environment.
> 
> The default assignment of SDK_PS1 is '?=', you can set it in conf file to override it.

I've held off this patch for a while since I think its going to
*really* annoy a subset of users and as Chris says, it can't
be disabled. It would really need to be disablable through configuration
and at runtime when sourcing the script which isn't possible.

I appreciate the usability issue it is trying to improve but
I think it will cause more complaints than issues it solves.
As such I don't think we want to do this...

Cheers,

Richard





  parent reply	other threads:[~2021-02-26 11:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  5:59 [PATCH v2] toolchain-scripts.bbclass: customize prompt string for SDKs kai
2021-02-25 15:29 ` [OE-core] " Christopher Larson
2021-02-26  1:57   ` kai
2021-02-26  2:39     ` Christopher Larson
2021-02-26 11:02     ` Richard Purdie [this message]
2021-02-26 17:25       ` kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f073090d3108e89bfb8ef59fdccd42b472df782b.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=kai.kang@windriver.com \
    --cc=kergoth@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox