From: "Sinan Kaya" <okaya@kernel.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 4/4] initscripts: Use initctl on sysvinit only
Date: Fri, 18 Dec 2020 14:18:50 -0500 [thread overview]
Message-ID: <f11cda3f-80c0-ecab-3efe-aaff5fe4c36c@kernel.org> (raw)
In-Reply-To: <CAMKF1sqyB+ow5uNd5LDLZt=rNZc_PqdkCkYASHxZyPkHJ0qZgw@mail.gmail.com>
On 12/18/2020 1:46 PM, Khem Raj wrote:
> On Fri, Dec 18, 2020 at 10:29 AM Sinan Kaya <okaya@kernel.org
> <mailto:okaya@kernel.org>> wrote:
>
> On 12/17/2020 5:54 PM, Khem Raj wrote:
> > +if [ ! -p "$INITCTL" ] && [ "$(readlink -- "/sbin/init")" =
> "/sbin/init.sysvinit" ]; then
>
> Can this be done at build time for targets using sysvinit only?
>
>
> Yes however It will be lot more obscure
> Hard to read and harder to maintain
I see your point. I think having a flag in the /etc/default/rcS file and
using that for comparison seems more plausible here as opposed to
init.sysvinit check. (this looked very fragile to me for some reason)
next prev parent reply other threads:[~2020-12-18 19:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 22:54 [PATCH 1/4] initscripts: use quotes for shell variable comparision Khem Raj
2020-12-17 22:54 ` [PATCH 2/4] busybox: Install /etc/default/rcS when used as init system Khem Raj
2020-12-17 22:54 ` [PATCH 3/4] busybox: Run mdev as daemon Khem Raj
2020-12-17 23:59 ` [OE-core] " Andre McCurdy
2020-12-18 2:45 ` Christopher Larson
2020-12-18 3:52 ` Khem Raj
2020-12-18 6:07 ` Andre McCurdy
2020-12-18 16:33 ` Khem Raj
2020-12-17 22:54 ` [PATCH 4/4] initscripts: Use initctl on sysvinit only Khem Raj
2020-12-18 18:29 ` [OE-core] " Sinan Kaya
2020-12-18 18:46 ` Khem Raj
2020-12-18 19:18 ` Sinan Kaya [this message]
2020-12-19 1:56 ` Khem Raj
2020-12-18 18:49 ` Peter Kjellerstedt
2020-12-17 23:51 ` [OE-core] [PATCH 1/4] initscripts: use quotes for shell variable comparision Andre McCurdy
2020-12-17 23:53 ` Khem Raj
2020-12-18 0:02 ` Andre McCurdy
2020-12-18 3:53 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11cda3f-80c0-ecab-3efe-aaff5fe4c36c@kernel.org \
--to=okaya@kernel.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox