From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.groups.io with SMTP id smtpd.web09.9017.1615816667272713176 for ; Mon, 15 Mar 2021 06:57:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=JXH95KCV; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.51, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f51.google.com with SMTP id g8so8184889wmd.4 for ; Mon, 15 Mar 2021 06:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=pqwMz6ZvDc/aUfLwcLMUPoHNXJxJPvLcI+E0ZsNq6CM=; b=JXH95KCVIlhbuGBsTL2MpU+SZwoLMriJ5Q6LCos7A6cN7Za/GIZxp9TBgtoi2flPUJ +5K1w0bk0u9Lf5s3KkUuC8N44DoyMsdevylgcWftBNePvmoHBDOcYhN0xllSYArtNMVZ ezDW/iTZ35wu3DZjsIfGx+9LzzhzC628UZVN4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=pqwMz6ZvDc/aUfLwcLMUPoHNXJxJPvLcI+E0ZsNq6CM=; b=ovt228rwna70J/V1sa8tOcVfVmES0XgqgOsncJHYfbo5fLNr9qa2I+FrfkIfKduwpj BkNk87M9jziNMgFonOWRmlsiioYRoyPrk+s60tSPgAsUE1IUPwbw7201+otIWbpF2f4X 1qV8474Ac5UyekRh8V39cJFfByJL/ug5YQjS1q12pBKLBP+1uINmcS7gaB+XnO/+D8+O +pYjxRsFV3TOV3eTLIZ1tBcpfjCH6v+eZ5qZ8lC1MQpbW0ZT9MFazlx8AyEc9gN4wKUd 3xfPaPHyb7HkGj55FbafLznur+JzmBwj6DbkmtKU7mJpC0Bj6ARUY7QBZqbK71oL87Bn CakQ== X-Gm-Message-State: AOAM532hPAUbxrS0fFmdsCf/ng0CwtBzZHXKYyNTGdykDUPULwMJtc82 Dyn9UsuF9EFmiGY88aiM6hwDkg== X-Google-Smtp-Source: ABdhPJw630D0waVAv4XZvMzNOS7e09zfuOhdCeMyAq4JZ2kU1u8MMyd6B0ogsaKqdjSaeZ8dJYZQtA== X-Received: by 2002:a1c:dd89:: with SMTP id u131mr25613075wmg.54.1615816665818; Mon, 15 Mar 2021 06:57:45 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8b0:aba:5f3c:4ab3:e50e:5e50:fc1e? ([2001:8b0:aba:5f3c:4ab3:e50e:5e50:fc1e]) by smtp.gmail.com with ESMTPSA id r10sm14623781wmh.45.2021.03.15.06.57.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 06:57:45 -0700 (PDT) Message-ID: Subject: Re: [OE-core] [PATCH v11] util-linux: split uuid in separate recipe to allow bootstrapping From: "Richard Purdie" To: Martin Jansa Cc: Luca Boccassi , openembedded-core@lists.openembedded.org, bluelightning@bluelightning.org Date: Mon, 15 Mar 2021 13:57:42 +0000 In-Reply-To: <20210315135555.hlkwmj4yj5ugw2he@jama> References: <20201210184632.3448265-1-luca.boccassi@gmail.com> <20210311150959.782186-1-luca.boccassi@gmail.com> <39f7cdcc297fb447632b8b8f222c1a80d88d0871.camel@linuxfoundation.org> <96cb1cfec8dca5eeca800aa238cab4912701621e.camel@gmail.com> <307a85e26da1a6fb90c274da8dbb5fbea457a156.camel@linuxfoundation.org> <764f13d7a09be6a0d992651ca0f95b9180284544.camel@gmail.com> <82b8349fa9de8918ddcb70993e438d9795de4700.camel@linuxfoundation.org> <20210315135555.hlkwmj4yj5ugw2he@jama> User-Agent: Evolution 3.39.2-1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Mon, 2021-03-15 at 14:55 +0100, Martin Jansa wrote: > On Mon, Mar 15, 2021 at 12:21:37PM +0000, Richard Purdie wrote: > > On Mon, 2021-03-15 at 11:50 +0000, Luca Boccassi wrote: > > > On Mon, 2021-03-15 at 10:49 +0000, Richard Purdie wrote: > > > > On Mon, 2021-03-15 at 10:44 +0000, Luca Boccassi wrote: > > > > > On Sun, 2021-03-14 at 22:10 +0000, Richard Purdie wrote: > > > > > > On Thu, 2021-03-11 at 15:09 +0000, luca.boccassi@gmail.com wrote: > > > > > > > From: Luca Boccassi > > > > > > > > > > > > > > Recently util-linux gained an (optional) build dependency on libcryptsetup. > > > > > > > But libcryptsetup build-depends on util-linux for blkid (optional, can be disabled) > > > > > > > and uuid (mandatory). > > > > > > > Split out util-linux-uuid in a different recipe to break the cycle. > > > > > > > > > > > > > > https://github.com/karelzak/util-linux/pull/898 > > > > > > > > > > > > > > Signed-off-by: Luca Boccassi > > > > > > > > > > > > Unfortunately I noticed we had a performance regression in buildtimes in > > > > > > recent changes. The closest I have this narrowed down to so far: > > > > > > > > > > > > https://autobuilder.yocto.io/pub/non-release/20210314-14/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210314181831_d42487bf52.html > > > > > > > > > > > > suggests it may be this change. I have more tests queued to confirm > > > > > > that definitively, if so we'll have to figure out why as this shouldn't > > > > > > really happen, its an 8% regression :(. > > > > > > > > > > Very strange that a single recipe could do that - is there something > > > > > wrong in the new .bb that I missed and could cause this? > > > > > > > > I'm wondering if it is because we're building util-linux twice now and > > > > there is some key choke point in the dependency chain. I have no evidence > > > > for that yet, it is just speculation though. > > > > > > With the autoconf options I've set, on my laptop it takes 32s to do > > > configure + make -j2. Most of that is autoconf - make -j2 takes 8s. > > > > > > Only 3 libraries are built with this combination: libcommon.a, > > > libtcolors.a, and libuuid.a/so. No executables or anything else is > > > built. It doesn't look like libtcolors is actually needed, I'll see if > > > I can prepare a patch to skip it, but I don't think it will buy more > > > than 1s, it's just two object files. > > > > > > The good news is that meson support is about to land upstream, which > > > should be significantly faster than autoconf + make: > > > > > > https://github.com/karelzak/util-linux/commits/topic/meson > > > > Meson definitely improves the speed! I was wondering if it was from > > configure for example. > > > > I now have more performance test results in (takes time to interleave  > > them with testing of master): > > > > https://autobuilder.yocto.io/pub/non-release/20210315-1/testresults/buildperf-ubuntu1604/perf-ubuntu1604_master_20210315005048_6bb1621815.html > > > > and I think this means it isn't from the util-linux change but one of  > > another three. I'm not entirely convinced those changes could do this > > but it is what the data says.  > > > > I've queued more bisection to narrow it down from there... > > BTW: this split also needs manual cleanup in the TMPDIR, right? It shouldn't. The system should spot that util-linux has changed and uninstall it from the sysroots as it goes. There is something not working right there :( Cheers, Richard